composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-06-23 00:06:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

✅ Add comment on dictionary tests to explain how uncomplete they are compared to whet they seem to do

Browse Source
This commit is contained in:
Molkobain
2026-06-20 10:27:58 +02:00
parent 9a93bcb06f
commit ff2357473b
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php
View File

@@ -391,6 +391,10 @@ EOF
}
/**
* Note: This test is not optimal!
* It checks if a dict entry is present in the same file but *accross different `Dict::Add()` sections*.
* If the dict entry is present multiple times within the same `Dict::Add()` section, it won't be detected as the test evaluates the PHP files which deduplicate the hash array, making the algorythm unaccurate.
*
* @dataProvider DictionaryFileProvider
*/
public function testDictKeyDefinedOncePerFile(string $sDictFileToTestFullPath): void
@@ -409,6 +413,10 @@ EOF
}
/**
* Note: This test is not optimal!
* It checks if a dict entry is present in the same file but *accross different `Dict::Add()` sections*.
* If the dict entry is present multiple times within the same `Dict::Add()` section, it won't be detected as the test evaluates the PHP files which deduplicate the hash array, making the algorythm unaccurate.
*
* @dataProvider GetLanguagesData
*
* @param string $sLang