From ff2357473bcde7c35ea75deb2ce083e878282670 Mon Sep 17 00:00:00 2001 From: Molkobain Date: Sat, 20 Jun 2026 10:27:58 +0200 Subject: [PATCH] :white_check_mark: Add comment on dictionary tests to explain how uncomplete they are compared to whet they seem to do --- .../integration-tests/DictionariesConsistencyTest.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php b/tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php index ca5ab5a581..5e5e663ccd 100644 --- a/tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php +++ b/tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php @@ -391,6 +391,10 @@ EOF } /** + * Note: This test is not optimal! + * It checks if a dict entry is present in the same file but *accross different `Dict::Add()` sections*. + * If the dict entry is present multiple times within the same `Dict::Add()` section, it won't be detected as the test evaluates the PHP files which deduplicate the hash array, making the algorythm unaccurate. + * * @dataProvider DictionaryFileProvider */ public function testDictKeyDefinedOncePerFile(string $sDictFileToTestFullPath): void @@ -409,6 +413,10 @@ EOF } /** + * Note: This test is not optimal! + * It checks if a dict entry is present in the same file but *accross different `Dict::Add()` sections*. + * If the dict entry is present multiple times within the same `Dict::Add()` section, it won't be detected as the test evaluates the PHP files which deduplicate the hash array, making the algorythm unaccurate. + * * @dataProvider GetLanguagesData * * @param string $sLang