composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-12 23:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°4517 - PHP 8.1 compatibility: Replace strlen with Utils::StrLen to avoid null value issue

Browse Source
This commit is contained in:
Benjamin Dalsass
2022-06-30 15:12:59 +02:00
parent acd5547618
commit f13ed9494b
1 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
sources/Application/Search/CriterionConversion/criteriontooql.class.inc.php
View File

@@ -119,8 +119,7 @@ class CriterionToOQL extends CriterionConversionAbstract
$aValues = self::GetValues($aCriteria);
$sValue = self::GetValue($aValues, 0);
if (!strlen($sValue))
{
if (!Utils::StrLen($sValue)) {
return "1";
}
@@ -132,8 +131,7 @@ class CriterionToOQL extends CriterionConversionAbstract
$aValues = self::GetValues($aCriteria);
$sValue = self::GetValue($aValues, 0);
if (!strlen($sValue))
{
if (!Utils::StrLen($sValue)) {
return "1";
}
@@ -145,8 +143,7 @@ class CriterionToOQL extends CriterionConversionAbstract
$aValues = self::GetValues($aCriteria);
$sValue = self::GetValue($aValues, 0);
if (!strlen($sValue))
{
if (!Utils::StrLen($sValue)) {
return "1";
}
@@ -162,8 +159,7 @@ class CriterionToOQL extends CriterionConversionAbstract
return "({$sRef} = '0')";
}
if (!strlen($sValue) && (!(isset($aCriteria['has_undefined'])) || !($aCriteria['has_undefined'])))
{
if (!Utils::StrLen($sValue) && (!(isset($aCriteria['has_undefined'])) || !($aCriteria['has_undefined']))) {
return "1";
}
@@ -175,8 +171,7 @@ class CriterionToOQL extends CriterionConversionAbstract
$aValues = self::GetValues($aCriteria);
$sValue = self::GetValue($aValues, 0);
if (!strlen($sValue))
{
if (!Utils::StrLen($sValue)) {
return "1";
}
@@ -191,12 +186,9 @@ class CriterionToOQL extends CriterionConversionAbstract
for($i = 0; $i < count($aValues); $i++)
{
$sRawValue = self::GetValue($aValues, $i);
if (strlen($sRawValue) == 0)
{
if (!Utils::StrLen($sRawValue)) {
$bHasUnDefined = true;
}
else
{
} else {
$aRawValues[] = $sRawValue;
}
}