From f13ed9494b59da94c1ad33a0c2a541b45e0dbef1 Mon Sep 17 00:00:00 2001
From: Benjamin Dalsass <benjamin.dalsass@combodo.com>
Date: Thu, 30 Jun 2022 15:12:59 +0200
Subject: [PATCH] =?UTF-8?q?N=C2=B04517=20-=20PHP=208.1=20compatibility:=20?=
 =?UTF-8?q?Replace=20strlen=20with=20Utils::StrLen=20to=20avoid=20null=20v?=
 =?UTF-8?q?alue=20issue?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../criteriontooql.class.inc.php              | 22 ++++++-------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/sources/Application/Search/CriterionConversion/criteriontooql.class.inc.php b/sources/Application/Search/CriterionConversion/criteriontooql.class.inc.php
index bfd291e7f..a3f61b8f5 100644
--- a/sources/Application/Search/CriterionConversion/criteriontooql.class.inc.php
+++ b/sources/Application/Search/CriterionConversion/criteriontooql.class.inc.php
@@ -119,8 +119,7 @@ class CriterionToOQL extends CriterionConversionAbstract
 		$aValues = self::GetValues($aCriteria);
 		$sValue = self::GetValue($aValues, 0);
 
-		if (!strlen($sValue))
-		{
+		if (!Utils::StrLen($sValue)) {
 			return "1";
 		}
 
@@ -132,8 +131,7 @@ class CriterionToOQL extends CriterionConversionAbstract
 		$aValues = self::GetValues($aCriteria);
 		$sValue = self::GetValue($aValues, 0);
 
-		if (!strlen($sValue))
-		{
+		if (!Utils::StrLen($sValue)) {
 			return "1";
 		}
 
@@ -145,8 +143,7 @@ class CriterionToOQL extends CriterionConversionAbstract
 		$aValues = self::GetValues($aCriteria);
 		$sValue = self::GetValue($aValues, 0);
 
-		if (!strlen($sValue))
-		{
+		if (!Utils::StrLen($sValue)) {
 			return "1";
 		}
 
@@ -162,8 +159,7 @@ class CriterionToOQL extends CriterionConversionAbstract
 			return "({$sRef} = '0')";
 		}
 
-		if (!strlen($sValue) && (!(isset($aCriteria['has_undefined'])) || !($aCriteria['has_undefined'])))
-		{
+		if (!Utils::StrLen($sValue) && (!(isset($aCriteria['has_undefined'])) || !($aCriteria['has_undefined']))) {
 			return "1";
 		}
 
@@ -175,8 +171,7 @@ class CriterionToOQL extends CriterionConversionAbstract
 		$aValues = self::GetValues($aCriteria);
 		$sValue = self::GetValue($aValues, 0);
 
-		if (!strlen($sValue))
-		{
+		if (!Utils::StrLen($sValue)) {
 			return "1";
 		}
 
@@ -191,12 +186,9 @@ class CriterionToOQL extends CriterionConversionAbstract
 		for($i = 0; $i < count($aValues); $i++)
 		{
 			$sRawValue = self::GetValue($aValues, $i);
-			if (strlen($sRawValue) == 0)
-			{
+			if (!Utils::StrLen($sRawValue)) {
 				$bHasUnDefined = true;
-			}
-			else
-			{
+			} else {
 				$aRawValues[] = $sRawValue;
 			}
 		}