mirror of
https://github.com/Combodo/iTop.git
synced 2026-02-13 07:24:13 +01:00
code style last test cleanup review + enhance UI output and display only failed module dependencies real life test cleanup review: add more tests + refacto code review: enhance algo and APIs review: renaming enhance test coverage refactoring renaming + reorder functions/tests compute GetDependencyResolutionFeedback in Module class review2 : renaming things fix rebase + code formatting fix code formatting review changes refactoring: code cleanup/standardization/remove all prototype stuffs refactoring: code cleanup/standardization/remove all prototype stuffs add deps validation to extension ci job fix ci fix ci: test broken when dir to scan did not exist like production-modules fix tests module dependency validation moved in a core folder + cleanup dedicated unit/integration tests forget dependency computation optimization seen as too risky + keep only user friendly sort in case of setup error rebase on develop + split new sort computation apart from modulediscovery revert to previous legacy order + gather new module computation classes in a dedicated folder make validation work (dirty way) + cleanup make setup deterministic: complete dependency order with alphabetical one when 2 module elements are at same position final deps validation bases on DM and PHP classes init in beforeclass + read defined classes/interfaces by module module discovery classes renaming to avoid collision with customer DM definitions read module file data apart from ModuleDiscovery cleanup cleanup fix inconsistent module dependencies fix integration check save tmp work before trying to fetch other wml deps fix module dependencies fix DM filename typo rename ModuleXXX classes by iTopCoreModuleXXX to reduce collisions with extensions add phpdoc + add more tests module dependency optimization - refacto + dependency new sort order module dependency optimization - stop computation when no new dependency is resolved enhance module dependency computation for optimization and admin feedback
130 lines
3.3 KiB
PHP
130 lines
3.3 KiB
PHP
<?php
|
|
|
|
namespace Combodo\iTop\Setup\ModuleDependency;
|
|
|
|
require_once(__DIR__.'/dependencyexpression.class.inc.php');
|
|
use ModuleDiscovery;
|
|
|
|
/**
|
|
* Class that handles a modules and all its dependencies
|
|
*/
|
|
class Module
|
|
{
|
|
private string $sModuleId;
|
|
private string $sModuleName;
|
|
private string $sVersion;
|
|
|
|
/**
|
|
* @var array<string> $aInitialDependencyExpressions
|
|
*/
|
|
private array $aInitialDependencyExpressions;
|
|
|
|
/**
|
|
* @var array<string, DependencyExpression> $aRemainingDependenciesToResolve
|
|
*/
|
|
public array $aRemainingDependenciesToResolve;
|
|
|
|
public function __construct(string $sModuleId)
|
|
{
|
|
$this->sModuleId = $sModuleId;
|
|
list($this->sModuleName, $this->sVersion) = ModuleDiscovery::GetModuleName($sModuleId);
|
|
}
|
|
|
|
public function IsDependencyExpressionResolved(string $sDependencyExpression): bool
|
|
{
|
|
return ! array_key_exists($sDependencyExpression, $this->aRemainingDependenciesToResolve);
|
|
}
|
|
|
|
public function GetDependencyResolutionFeedback(): array
|
|
{
|
|
$aDepsWithIcons = [];
|
|
|
|
foreach ($this->aInitialDependencyExpressions as $sDependencyExpression) {
|
|
if (! $this->IsDependencyExpressionResolved($sDependencyExpression)) {
|
|
$aDepsWithIcons[] = '❌ '.$sDependencyExpression;
|
|
}
|
|
}
|
|
return $aDepsWithIcons;
|
|
}
|
|
|
|
/**
|
|
* @return string
|
|
*/
|
|
public function GetModuleName()
|
|
{
|
|
return $this->sModuleName;
|
|
}
|
|
|
|
/**
|
|
* @return string
|
|
*/
|
|
public function GetVersion()
|
|
{
|
|
return $this->sVersion;
|
|
}
|
|
|
|
/**
|
|
* @return string
|
|
*/
|
|
public function GetModuleId()
|
|
{
|
|
return $this->sModuleId;
|
|
}
|
|
|
|
/**
|
|
* @param array $aAllDependencyExpressions: list of dependencies (string)
|
|
*
|
|
* @return void
|
|
*/
|
|
public function SetDependencies(array $aAllDependencyExpressions): void
|
|
{
|
|
$this->aInitialDependencyExpressions = $aAllDependencyExpressions;
|
|
$this->aRemainingDependenciesToResolve = [];
|
|
|
|
foreach ($aAllDependencyExpressions as $sDependencyExpression) {
|
|
$this->aRemainingDependenciesToResolve[$sDependencyExpression] = new DependencyExpression($sDependencyExpression);
|
|
}
|
|
}
|
|
|
|
public function IsResolved(): bool
|
|
{
|
|
return (0 === count($this->aRemainingDependenciesToResolve));
|
|
}
|
|
|
|
/**
|
|
* Check if module dependencies are resolved with current list of module versions
|
|
* @param array $aModuleVersions : versions by module names dict
|
|
* @param array $aSelectedModules : modules names dict
|
|
*
|
|
* @return void
|
|
*/
|
|
public function UpdateModuleResolutionState(array $aModuleVersions, array $aSelectedModules): void
|
|
{
|
|
$aNextDependencies = [];
|
|
|
|
foreach ($this->aRemainingDependenciesToResolve as $sDependencyExpression => $oModuleDependency) {
|
|
/** @var DependencyExpression $oModuleDependency*/
|
|
$oModuleDependency->UpdateModuleResolutionState($aModuleVersions, $aSelectedModules);
|
|
if (!$oModuleDependency->IsResolved()) {
|
|
$aNextDependencies[$sDependencyExpression] = $oModuleDependency;
|
|
}
|
|
}
|
|
|
|
$this->aRemainingDependenciesToResolve = $aNextDependencies;
|
|
}
|
|
|
|
/**
|
|
* @return array: list of unique module names
|
|
*/
|
|
public function GetUnresolvedDependencyModuleNames(): array
|
|
{
|
|
$aRes = [];
|
|
foreach ($this->aRemainingDependenciesToResolve as $sDependencyExpression => $oModuleDependency) {
|
|
/** @var DependencyExpression $oModuleDependency */
|
|
$aRes = array_merge($aRes, $oModuleDependency->GetRemainingModuleNamesToResolve());
|
|
}
|
|
|
|
return array_unique($aRes);
|
|
}
|
|
}
|