N°9699 - Enable AddMeToContact without write access on Ticket

datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml

@@ -300,7 +300,7 @@
             *
             * Add the current contact associated Person to the contacts_list of this Ticket
             * No error if there is no associated Person or if the Person is already in the list
-            * @return bool Return true on success
+            * @return bool Return true if link was created, false otherwise
             */
           </comment>
           <static>false</static>
@@ -314,12 +314,11 @@
                 $oLnk = MetaModel::NewObject('lnkContactToTicket');
                 $oLnk->Set('contact_id', $iPersonId);
                 $oLnk->Set('ticket_id', $this->GetKey());
-                $oContactsSet->AddItem($oLnk);
-                $this->Set('contacts_list', $oContactsSet);
-                $this->DBUpdate();
+                $oLnk->DBInsert();
+                return true;
             }
 	      }
-		    return true;
+	      return false;
 	  }]]></code>
           <arguments/>
         </method>
@@ -328,7 +327,7 @@
             *
             * Remove the current user associated Person from the contacts_list of this Ticket
             * No error if there is no associated Person or if the Person is not in the list
-            * @return bool Return true
+            * @return bool Return true if link was deleted, false otherwise
             */
           </comment>
           <static>false</static>
@@ -340,14 +339,12 @@
             $oContactsSet = $this->Get('contacts_list');
             foreach ($oContactsSet as $oLnk) {
                 if ($oLnk->Get('contact_id') == $iPersonId) {
-                    $oContactsSet->RemoveItem($oLnk->GetKey());
-                    $this->Set('contacts_list', $oContactsSet);
-                    $this->DBUpdate();
+                    $oLnk->DBDelete();
                     return true;
                 }
             }
         }
-      return true;
+        return false;
 	  }]]></code>
           <arguments/>
         </method>

dictionaries/ui/layouts/extensions-details/cs.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('CS CZ', 'Czech', 'Čeština', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/da.dictionary.itop.extensions-details.php

@@ -10,19 +10,13 @@
 /**
  *
  */
-Dict::Add('DA DK', 'Danish', 'Dansk', [
+Dict::Add('DA DA', 'Danish', 'Dansk', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/de.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('DE DE', 'German', 'Deutsch', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/en.dictionary.itop.extensions-details.php

@@ -10,17 +10,11 @@
 
 Dict::Add('EN US', 'English', 'English', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall',

dictionaries/ui/layouts/extensions-details/es_cr.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('ES CR', 'Spanish', 'Español, Castellano', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/fr.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('FR FR', 'French', 'Français', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installé',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'L\'extension est installée sur cette instance d\'iTop',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'va être installé',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'Cette extension va être installée',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'pas installé',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'L\'extension n\'est pas installée sur cette instance d\'iTop',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'va être désinstallé',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'Cette extension va être désinstallée',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'non désinstallable',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'Cette extension ne peut pas être désinstallée (requise/protégée)',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'supprimé du disque',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'Les fichiers de l\'extension sont manquants sur le disque',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'À propos de  %1$s',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'Plus d\'informations',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Forcer la désinstallation',

dictionaries/ui/layouts/extensions-details/hu.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('HU HU', 'Hungarian', 'Magyar', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/it.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('IT IT', 'Italian', 'Italiano', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/ja.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('JA JP', 'Japanese', '日本語', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/nl.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('NL NL', 'Dutch', 'Nederlands', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/pl.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('PL PL', 'Polish', 'Polski', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/pt_br.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('PT BR', 'Brazilian', 'Brazilian', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/ru.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('RU RU', 'Russian', 'Русский', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/sk.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('SK SK', 'Slovak', 'Slovenčina', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/tr.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('TR TR', 'Turkish', 'Türkçe', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

dictionaries/ui/layouts/extensions-details/zh_cn.dictionary.itop.extensions-details.php

@@ -12,17 +12,11 @@
  */
 Dict::Add('ZH CN', 'Chinese', '简体中文', [
 	'UI:Layout:ExtensionsDetails:BadgeInstalled' => 'installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeInstalled+' => 'The extension is installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled' => 'to be installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeInstalled+' => 'This extension is marked to be installed~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotInstalled' => 'not installed~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotInstalled+' => 'The extension is not currently installed on this iTop instance~~',
 	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled' => 'to be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+' => 'This extension is marked to be uninstalled~~',
 	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable' => 'cannot be uninstalled~~',
-	'UI:Layout:ExtensionsDetails:BadgeNotUninstallable+' => 'This extension cannot be uninstalled (required or protected)~~',
 	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk' => 'missing from disk~~',
-	'UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+' => 'The extension files are missing from disk~~',
 	'UI:Layout:ExtensionsDetails:MenuAboutTitle' => 'About %1$s~~',
 	'UI:Layout:ExtensionsDetails:MenuAbout' => 'More informations~~',
 	'UI:Layout:ExtensionsDetails:MenuForce' => 'Force uninstall~~',

sources/Application/UI/Base/Layout/Extension/ExtensionDetailsUIBlockFactory.php

@@ -21,19 +21,11 @@ class ExtensionDetailsUIBlockFactory extends AbstractUIBlockFactory
 		$bSelected = $aExtraFlags['selected'] ?? true;
 		$bDisabled = $aExtraFlags['disabled'] ?? false;
 		$bRemote = $aExtraFlags['remote'] ?? false;
-		self::AddExtraBadges($aBadges, $bUninstallable, $bMissingFromDisk, $sCode);
-		$oBadgeInstalled = BadgeUIBlockFactory::MakeGreen(
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeInstalled'),
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeInstalled+'),
-			'badge--'.$sCode.'--installed'
-		);
+		self::AddExtraBadges($aBadges, $bUninstallable, $bMissingFromDisk);
+		$oBadgeInstalled = BadgeUIBlockFactory::MakeGreen(Dict::S('UI:Layout:ExtensionsDetails:BadgeInstalled'));
 		$oBadgeInstalled->AddCSSClass('checked');
 		$aBadges[] = $oBadgeInstalled;
-		$oBadgeToBeUninstalled = BadgeUIBlockFactory::MakeRed(
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeUninstalled'),
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeUninstalled+'),
-			'badge--'.$sCode.'--to-be-uninstalled'
-		);
+		$oBadgeToBeUninstalled = BadgeUIBlockFactory::MakeRed(Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeUninstalled'));
 		$oBadgeToBeUninstalled->AddCSSClass('unchecked');
 		$aBadges[] = $oBadgeToBeUninstalled;
 
@@ -64,19 +56,11 @@ class ExtensionDetailsUIBlockFactory extends AbstractUIBlockFactory
 		$bUninstallable = $aExtraFlags['uninstallable'] ?? true;
 		$bSelected = $aExtraFlags['selected'] ?? false;
 		$bDisabled = $aExtraFlags['disabled'] ?? false;
-		self::AddExtraBadges($aBadges, $bUninstallable, false, $sCode);
-		$oBadgeInstalled = BadgeUIBlockFactory::MakeGrey(
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeNotInstalled'),
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeNotInstalled+'),
-			'badge--'.$sCode.'--not-installed'
-		);
+		self::AddExtraBadges($aBadges, $bUninstallable, false);
+		$oBadgeInstalled = BadgeUIBlockFactory::MakeGrey(Dict::S('UI:Layout:ExtensionsDetails:BadgeNotInstalled'));
 		$oBadgeInstalled->AddCSSClass('unchecked');
 		$aBadges[] = $oBadgeInstalled;
-		$oBadgeToBeUninstalled = BadgeUIBlockFactory::MakeCyan(
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeInstalled'),
-			Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeInstalled+'),
-			'badge--'.$sCode.'--to-be-installed'
-		);
+		$oBadgeToBeUninstalled = BadgeUIBlockFactory::MakeCyan(Dict::S('UI:Layout:ExtensionsDetails:BadgeToBeInstalled'));
 		$oBadgeToBeUninstalled->AddCSSClass('checked');
 		$aBadges[] = $oBadgeToBeUninstalled;
 		$oExtensionDetails = new ExtensionDetails($sCode, $sLabel, $sDescription, $aMetaData, $aBadges, $sAbout);
@@ -92,21 +76,13 @@ class ExtensionDetailsUIBlockFactory extends AbstractUIBlockFactory
 		return $oExtensionDetails;
 	}
 
-	private static function AddExtraBadges(array &$aBadges, bool $bUninstallable, bool $bMissingFromDisk, string $sCode)
+	private static function AddExtraBadges(array &$aBadges, bool $bUninstallable, bool $bMissingFromDisk)
 	{
 		if (!$bUninstallable) {
-			$aBadges[] = BadgeUIBlockFactory::MakeOrange(
-				Dict::S('UI:Layout:ExtensionsDetails:BadgeNotUninstallable'),
-				Dict::S('UI:Layout:ExtensionsDetails:BadgeNotUninstallable+'),
-				'badge--'.$sCode.'--not-uninstallable'
-			);
+			$aBadges[] = BadgeUIBlockFactory::MakeOrange(Dict::S('UI:Layout:ExtensionsDetails:BadgeNotUninstallable'));
 		}
 		if ($bMissingFromDisk) {
-			$aBadges[] = BadgeUIBlockFactory::MakeRed(
-				Dict::S('UI:Layout:ExtensionsDetails:BadgeMissingFromDisk'),
-				Dict::S('UI:Layout:ExtensionsDetails:BadgeMissingFromDisk+'),
-				'badge--'.$sCode.'--missing-from-disk'
-			);
+			$aBadges[] = BadgeUIBlockFactory::MakeRed(Dict::S('UI:Layout:ExtensionsDetails:BadgeMissingFromDisk'));
 		}
 	}
 }