N°8681 - Fix PHP code styles

* N°8681 - PHP 8.1: Fix deprecated notice for null value passed to preg_match_all()

* N°8681 - Add unit tests

* N°8681 - Add unit tests

core/attributedef.class.inc.php

@@ -4259,6 +4259,9 @@ class AttributeText extends AttributeString
 
 	public static function RenderWikiHtml($sText, $bWikiOnly = false)
 	{
+		// N°8681 - Ensure to have a string value
+		$sText = $sText ?? '';
+
 		if (!$bWikiOnly) {
 			$sPattern = '/'.str_replace('/', '\/', utils::GetConfig()->Get('url_validation_pattern')).'/i';
 			if (preg_match_all(

core/inlineimage.class.inc.php

@@ -266,6 +266,9 @@ class InlineImage extends DBObject
 	 */
 	public static function FixUrls($sHtml)
 	{
+		// N°8681 - Ensure to have a string value
+		$sHtml = $sHtml ?? '';
+
 		$aNeedles = [];
 		$aReplacements = [];
 		// Find img tags with an attribute data-img-id

tests/php-code-style/.php-cs-fixer.dist.php

@@ -13,13 +13,12 @@ $config = new PhpCsFixer\Config();
 return $config->setRiskyAllowed(true)
 	->setRules([
 		'@PSR12'       => true,
-		'indentation_type' => true,
-		'no_extra_blank_lines' => true,
-		'array_syntax' => ['syntax' => 'short'],
-		'concat_space' => true,
-		'trailing_comma_in_multiline' => true,
+		'no_extra_blank_lines' => true, // default value ['tokens' => ['extra']]
+		'array_syntax' => true, // default value ['syntax' => 'short']
+		'concat_space' => true, // default value ['spacing' => 'none']
+		'trailing_comma_in_multiline' => true, // default value ['after_heredoc' => false, 'elements' => ['arrays']]
 	])
 	->setIndent("\t")
 	->setLineEnding("\n")
 	->setFinder($finder)
-;
+;

tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php

@@ -13,13 +13,6 @@ class AttributeDefinitionTest extends ItopDataTestCase
 {
 	public const CREATE_TEST_ORG = true;
 
-	protected function setUp(): void
-	{
-		parent::setUp();
-		require_once(APPROOT.'core/attributedef.class.inc.php');
-
-	}
-
 	public function testGetImportColumns()
 	{
 		$oAttributeDefinition = MetaModel::GetAttributeDef("ApplicationSolution", "status");

tests/php-unit-tests/unitary-tests/core/AttributeTextTest.php

@@ -0,0 +1,79 @@
+<?php
+
+/*
+ * @copyright   Copyright (C) 2010-2026 Combodo SAS
+ * @license     http://opensource.org/licenses/AGPL-3.0
+ */
+
+namespace Combodo\iTop\Test\UnitTest\Core;
+
+use AttributeText;
+use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
+
+class AttributeTextTest extends ItopDataTestCase
+{
+	protected \Organization $oTestOrganizationForAttributeText;
+
+	public function setUp(): void
+	{
+		parent::setUp();
+		$this->oTestOrganizationForAttributeText = $this->CreateOrganization('Test for AttributeTextTest');
+	}
+
+	/**
+	 * @covers AttributeText::RenderWikiHtml
+	 */
+	public function testRenderWikiHtml_nonWikiUrlVariants()
+	{
+		// String value
+		$sInput = 'This hyperlink https://combodo.com should be in an anchor tag.';
+		$sExpected = 'This hyperlink <a href="https://combodo.com">https://combodo.com</a> should be in an anchor tag.';
+		$this->assertEquals($sExpected, AttributeText::RenderWikiHtml($sInput));
+
+		// Empty string value
+		$this->assertEquals('', AttributeText::RenderWikiHtml(''));
+
+		// Null value
+		$this->assertEquals('', AttributeText::RenderWikiHtml(null));
+	}
+
+	/**
+	 * @covers AttributeText::RenderWikiHtml
+	 */
+	public function testRenderWikiHtml_bWikiOnlyAbsentOrFalse_shouldTransformBothRegularAndWikiHyperlinks()
+	{
+		$sInput = 'A regular hyperlink https://combodo.com and a wiki hyperlink to an existing object [[Organization:'.$this->oTestOrganizationForAttributeText->GetKey().']]';
+
+		// bWikiOnly default value
+		$sResult = AttributeText::RenderWikiHtml($sInput);
+		$this->assertStringContainsString('<a href="https://combodo.com">', $sResult);
+		$this->assertStringContainsString('class="object-ref-link"', $sResult);
+
+		// bWikiOnly = false
+		$sResult = AttributeText::RenderWikiHtml($sInput, false);
+		$this->assertStringContainsString('<a href="https://combodo.com">', $sResult);
+		$this->assertStringContainsString('class="object-ref-link"', $sResult);
+	}
+
+	/**
+	 * @covers AttributeText::RenderWikiHtml
+	 */
+	public function testRenderWikiHtml_bWikiOnlyToTrue_shouldNotTransformRegularHyperlinkButTransformWikiHyperlink()
+	{
+		$sInput = 'A regular hyperlink https://combodo.com and a wiki hyperlink to an existing object [[Organization:'.$this->oTestOrganizationForAttributeText->GetKey().']]';
+		$sResult = AttributeText::RenderWikiHtml($sInput, true);
+		$this->assertStringNotContainsString('<a href="https://combodo.com">', $sResult);
+		$this->assertStringContainsString('class="object-ref-link"', $sResult);
+	}
+
+	/**
+	 * @covers AttributeText::RenderWikiHtml
+	 */
+	public function testRenderWikiHtml_shouldTransformWikiHyperlinkForExistingObjectsOnly()
+	{
+		$sInput = 'A wiki hyperlink to a non existing object [[Organization:123456789]]  and a wiki hyperlink to an existing object [[Organization:'.$this->oTestOrganizationForAttributeText->GetKey().']]';
+		$sResult = AttributeText::RenderWikiHtml($sInput);
+		$this->assertStringContainsString('wiki_broken_link', $sResult);
+		$this->assertStringContainsString('class="object-ref-link"', $sResult);
+	}
+}

tests/php-unit-tests/unitary-tests/core/InlineImageTest.php

@@ -59,4 +59,43 @@ class InlineImageTest extends ItopDataTestCase
 			],
 		];
 	}
+
+	/**
+	 * @covers InlineImage::FixUrls
+	 */
+	public function testFixUrls_shouldReturnAnEmptyStringIfNullOrEmptyStringPassed()
+	{
+		$sResult = InlineImage::FixUrls(null);
+		$this->assertEquals('', $sResult);
+
+		$sResult = InlineImage::FixUrls('');
+		$this->assertEquals('', $sResult);
+	}
+
+	/**
+	 * @covers InlineImage::FixUrls
+	 */
+	public function testFixUrls_shouldReturnUnchangedValueIfValueContainsNoImage()
+	{
+		$sHtml = '<div><p>Texte sans image</p></div>';
+		$sResult = InlineImage::FixUrls($sHtml);
+		$this->assertEquals($sHtml, $sResult);
+	}
+
+	/**
+	 * @covers InlineImage::FixUrls
+	 */
+	public function testFixUrls_shouldReplaceImagesSrcWithCurrentAppRootUrlAndSecret()
+	{
+		$sHtml = <<<HTML
+<div>
+	<img src="/images/test1.png" data-img-id="123" data-img-secret="abc" />
+	<img src="/images/test2.png" data-img-id="456" data-img-secret="def" />
+</div>
+HTML;
+		$sResult = InlineImage::FixUrls($sHtml);
+		$this->assertStringContainsString('<img', $sResult);
+		$this->assertStringContainsString(\utils::EscapeHtml(\utils::GetAbsoluteUrlAppRoot().INLINEIMAGE_DOWNLOAD_URL.'123&s=abc'), $sResult);
+		$this->assertStringContainsString(\utils::EscapeHtml(\utils::GetAbsoluteUrlAppRoot().INLINEIMAGE_DOWNLOAD_URL.'456&s=def'), $sResult);
+	}
 }