N°8726 - Deprecation cleanup in portal

- form handler

datamodels/2.x/itop-portal-base/portal/public/js/toolbox.js

@@ -22,29 +22,7 @@
  * @since 2.7.0
  */
 const CombodoPortalToolbox = {
-	/**
-	 * Close all opened modals on the page
-	 * @deprecated 3.1.0 Use CombodoModal.CloseAllModals() instead
-	 */
-	CloseAllModals: function() {
-		CombodoModal.CloseAllModals();
-	},
-	/**
-	 * @deprecated 3.1.0 Use CombodoModal.OpenUrlInModal() instead
-	 */
-	OpenUrlInModal: function(sTargetUrl, bCloseOtherModals) {
-		CombodoModal.OpenUrlInModal(sTargetUrl, bCloseOtherModals);
-	},
-	/**
-	 * @deprecated 3.1.0 Use CombodoModal.OpenModal() instead
-	 */
-	OpenModal: function(oOptions) {
-		// Default value fallback for calls prior to 3.1.0
-		if (oOptions.size === undefined) {
-			oOptions.size = 'lg';
-		}
-		return CombodoModal.OpenModal(oOptions);
-	},
+
 	/**
 	 * Generic function to call a specific endpoint with callbacks
 	 *

datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php

@@ -216,9 +216,6 @@ class ObjectFormHandlerHelper
 			$aNavigationRules = $this->oNavigationRuleHelper->PrepareRulesForForm($aFormProperties, $oObject, $bModal);
 			$aFormData['submit_rule'] = $aNavigationRules['submit'];
 			$aFormData['cancel_rule'] = $aNavigationRules['cancel'];
-			/** @deprecated We keep the "xxx_callback" name to keep compatibility with extensions using the portal_form_handler.js widget but they will be removed in a future version. */
-			$aFormData['submit_callback'] = $aNavigationRules['submit']['url'];
-			$aFormData['cancel_callback'] = $aNavigationRules['cancel']['url'];
 
 			// Preparing renderer
 			// Note : We might need to distinguish form & renderer endpoints

datamodels/2.x/itop-portal-base/portal/templates/layout.html.twig

@@ -286,18 +286,6 @@
 				};
                 // user preferences object
                 const oUserPreferences = new UserPreferences('{{ app['url_generator'].generate('p_preferences_set_preference')|raw }}');
-				/**
-				 * @param sUrl {string} The URL to append the new param to
-				 * @param sParamName {string} Name of the parameter
-				 * @param sParamValue {string} Value of the param, needs to be already URL encoded
-				 * @return {string} The sUrl parameters with the sParamName / sParamValue append at the right place
-				 * @deprecated 3.0.0 N°4176
-				 */
-				var AddParameterToUrl = function(sUrl, sParamName, sParamValue)
-				{
-					sUrl += (sUrl.split('?')[1] ? '&':'?') + sParamName + '=' + sParamValue;
-					return sUrl;
-				};
 				// Test is sString is a valid JSON string
 				// TODO 3.0.0: Move to CombodoGlobalToolbox and deprecate this one
 				var IsJSONString = function(sString)