Molkobain
f2d42a7e56
N°5002 - Simplify code
2022-05-20 18:41:39 +02:00
Benjamin Dalsass
d01e4b4a85
N°5168 - Security hardening
2022-05-20 16:08:25 +02:00
Pierre Goiffon
f57d1f1de3
✅ Fix PHPunit errors with InlineImageMock.php and UtilsTest
...
HTMLDOMSanitizerTest : fix "Fatal error: Cannot declare class InlineImage, because the name is already in use in /var/www/html/iTop/test/core/sanitizer/InlineImageMock.php"
We are now injecting the class to mock, instead of declaring another class with the same name (was working before but why ?!???)
\UtilsTest::testSanitizer : no more testing the "class" filter, because it is a simple indirection, and we need to load datamodel which is causing multiple problems (see the comment in the test method dataprovider)
2022-05-20 10:48:05 +02:00
acognet
16fcddc249
N°4867 - "Twig content not allowed" error when use the extkey widget search icon in the user portal (regression of N°4384 )
2022-05-20 09:52:25 +02:00
bdalsass
4dd384e418
N°4872 - Create a ticket in resolved statut Inlineimage disappear ( #294 )
2022-05-20 09:26:06 +02:00
Molkobain
80e7313b24
PHPDoc
2022-05-19 17:40:14 +02:00
Benjamin Dalsass
5f0a820b4a
N°4899 - add sanitizer url since annotation and tests for sanitizer function
2022-05-19 08:36:42 +02:00
Benjamin Dalsass
03ef4246bf
N°4899 - add sanitizer url since annotation and tests for sanitizer function
2022-05-18 12:03:07 +02:00
Pierre Goiffon
534e7cf59d
✅ N°4655 New nightly PHPUnit file containing OQL tests
...
Those tests were removed in 72af2b7c as they took too much time to run.
We are re-enabling them but only for nightly builds !
2022-05-18 09:35:13 +02:00
Benjamin Dalsass
61a2d200b4
N°4900 - Stored XSS in dashlets failed OQL query
2022-05-18 08:10:01 +02:00
Benjamin Dalsass
3d6bbe4029
Revert "N°4900 - Stored XSS in dashlets failed OQL query"
...
This reverts commit 562dd8fc21 .
2022-05-18 08:05:19 +02:00
Molkobain
eac6f07823
N°4985 - PHP 8.0: Fix optional parameter before mandatory parameter
...
* Method is always (once) called with the value defined in iTop
* No Combodo extension call the method
* No customization in the ITSM Designer (snippets / extensions) call the method
* Calling method with only the first parameter would crash anyway
2022-05-17 16:51:50 +02:00
Pierre Goiffon
424e2a5745
💡 Fix PHPDoc for \DBObject::CheckConsistency
2022-05-17 15:52:43 +02:00
Molkobain
0ef4fee0b4
N°4985 - PHP 8.0: Fix usort callback return type
2022-05-17 15:28:04 +02:00
Benjamin Dalsass
8e97279401
N°4899 - Reflected XSS on revert_dashboard operation
2022-05-17 09:27:06 +02:00
Benjamin Dalsass
59424c3126
N°4976 - CSRF in import page
2022-05-17 09:02:06 +02:00
Benjamin Dalsass
562dd8fc21
N°4900 - Stored XSS in dashlets failed OQL query
2022-05-17 08:20:26 +02:00
Molkobain
cf745554fb
N°4985 - PHP 8.0: Fix strlen() test condition that needs to be more strict
2022-05-16 18:04:29 +02:00
Molkobain
e909eac98e
N°4985 - PHP 8.0: Fix is_callable() first param syntax in ObjectFormManager
2022-05-16 17:44:34 +02:00
Molkobain
5e42efc3ec
N°4985 - PHP 8.0: Fix usort callback return type in portal's lists initialization
2022-05-16 17:44:33 +02:00
Molkobain
c2607c4223
N°5035 - Setup: Remove tracking image at the end of the setup
2022-05-09 13:55:06 +02:00
Pierre Goiffon
1fb0911710
🔧 N°3091 postbuild PHPunit XML : change html_errors PHP setting
2022-05-03 10:53:32 +02:00
Pierre Goiffon
b348e0ff27
🔧 N°3091 PHPunit XML : change html_errors PHP setting
...
We are outputting to console, and will get results in Jenkins or terminal, so no HTML please :o)
2022-05-03 10:51:48 +02:00
Pierre Goiffon
4646a05c7a
N°4824 Update consumers after swiftmailer/swiftmailer
...
Multiple things to do as there were some changes in 6.0
Reference : https://github.com/swiftmailer/swiftmailer/blob/master/CHANGES#L107
* Fix "Call to undefined method Swift_Message::newInstance()" exception in notifications
* Fix removed Swift_MailTransport
2022-05-03 09:35:48 +02:00
Pierre Goiffon
c5527c106c
🔧 N°3091 PHPunit XML : set columns
2022-05-02 15:33:39 +02:00
Pierre Goiffon
5eac1b8730
🔧 N°3091 PHPunit XML : fix correct PHP INI settings
...
see https://phpunit.readthedocs.io/en/8.5/configuration.html#the-php-element
2022-05-02 15:25:59 +02:00
Pierre Goiffon
0de15d040f
⬇️ N°4824 rollback scssphp/scssphp update (won't be done in this branch !)
2022-05-02 09:15:48 +02:00
Pierre Goiffon
c4ae94fd4c
Update denied test dirs
2022-04-29 17:15:50 +02:00
Pierre Goiffon
1e8818984e
📄 N°4284 Update licenses
2022-04-29 15:53:03 +02:00
Pierre Goiffon
a023f73509
N°4284 Update jquery UI SCSS to remove SCSSPHP warnings
...
Replace "Alpha(..." with "alpha(..."
Example of warning at compilation with SCSSPHP :
DEPRECATION WARNING: Calling built-in functions with a non-standard name is deprecated since Scssphp 1.8.0 and will not work anymore in 2.0 (they will be treated as CSS function calls instead).
Use "alpha" instead of "Alpha".
on line 55 of /var/www/html/iTop/css/../css/ui-lightness/jqueryui.scss
2022-04-29 15:39:26 +02:00
Pierre Goiffon
6f0e1a7f47
N°4824 Update consumers after swiftmailer/swiftmailer update
...
Also remove new Doctrine test dir (iTopComposerTest feedback)
2022-04-29 15:24:56 +02:00
Pierre Goiffon
0ef9bb1a47
⬆️ N°4824 Composer libs : update swiftmailer/swiftmailer
2022-04-29 15:24:56 +02:00
Pierre Goiffon
71ceedc4bb
🔨 N°4284 Detect new test dirs on composer update
2022-04-29 15:24:56 +02:00
Pierre Goiffon
73c3c1249f
⬆️ N°4824 Composer libs : update scssphp/scssphp
2022-04-29 15:24:56 +02:00
Pierre Goiffon
88a10dba28
N°4824 Update consumers after pelago/emogrifier update
2022-04-29 15:24:56 +02:00
Pierre Goiffon
001e222f67
⬆️ N°4824 Composer libs : update pelago/emogrifier
2022-04-29 15:24:56 +02:00
Pierre Goiffon
af8bcdc242
⬆️ N°4824 Composer libs : update pear/archive_tar
2022-04-29 15:24:56 +02:00
Pierre Goiffon
f4c7afc148
N°4824 Update consumers & tests after nikic/php-parser update
...
Was done in 3.0.0 with N°3867
(cherry picked from commit cd1ba097cb )
(cherry picked from commit 5b42f67a99 )
(cherry picked from commit 2d98ca2318 )
(cherry picked from commit ddc5bbd1bb )
2022-04-29 15:24:56 +02:00
Pierre Goiffon
b19c73a36e
⬆️ N°4284 Composer libs : update nikic/php-parser
...
Was done in 3.0.0 with N°3867
2022-04-29 15:24:55 +02:00
Pierre Goiffon
5fe0d0b94f
⬆️ N°4284 Composer libs : update combodo/tcpdf
2022-04-29 15:18:41 +02:00
Pierre Goiffon
f8d435d5f3
N°4284 Composer libs : refresh symfony
2022-04-29 15:18:41 +02:00
Pierre Goiffon
f15ef36fd1
➖ N°4284 Composer libs : remove symfony/polyfill-php70
...
Though it is still downloaded because asked by symfony framework, but as we don't need it in our code no need to specify it here !
2022-04-29 15:18:41 +02:00
Pierre Goiffon
64b25c4daa
📌 N°4284 Composer libs : fix twig/twig to ~1.42.5
...
Without specifying explicitly the Twig version, since the update of require php from 5.6 to 7.0 we are getting Twig 2.12.5 !
We don't want Twig 2 as this version changes the macro scope and causes massive changes in our code... This update will be done later in other branches.
2022-04-29 15:15:32 +02:00
Pierre Goiffon
d0ba0d193b
N°3091 iTopComposerTest : change deprecated PHPUnit method call
2022-04-22 14:42:12 +02:00
Pierre Goiffon
8e6e2432d3
Extensibility : iPortalUIExtension and AbstractPortalUIExtension aren't experimental anymore
2022-04-21 17:29:40 +02:00
Molkobain
83ec19dfca
Remove duplicated lines in .gitignore
2022-04-21 14:26:56 +02:00
Pierre Goiffon
6e619f2c35
Fix \iTopConfigParserTest::testConfigWriteToFile_FromScratchInstallation throwing error
2022-04-21 12:02:35 +02:00
Pierre Goiffon
163ba41e8d
N°3091 Update PHPUnit to 8.5 : remove doesNotPerformAssertions annotation
...
Modified tests :
- iTopConfigParsertest
- DBSearchIntersectTest::testIntersectOptimization
As expected this isn't working with PHPUnit 8.5
Why does it worked with previous PHPUnit 6 version ? Maybe this annotation wasn't handled yet ? The corresponding PHPUnit doc isn't available anymore...
Annotations doc for PHP 8.5 : https://phpunit.readthedocs.io/en/8.5/annotations.html#doesnotperformassertions
2022-04-21 12:02:35 +02:00
Pierre Goiffon
ec143c43db
N°3091 Update PHPUnit to 8.5 : fix setUp and teardDown methods signatures
...
"Return type declaration must be compatible with parent"
See https://phpunit.de/announcements/phpunit-8.html "Return Type of Template Methods"
2022-04-21 12:02:35 +02:00
Pierre Goiffon
cacf0004a5
🙈 N°3091 Update PHPUnit to 8.5 : add PHPunit cache file to ignore
...
We don't want to disable the feature, nor we want this file to be versionned
https://phpunit.readthedocs.io/en/8.5/configuration.html#the-cacheresult-attribute
2022-04-21 12:02:35 +02:00