odain
0b46ab9e48
ci: add phpunit defaultProfiles annotation + tag some tests with addition annotations to ease exclusion/inclusion mechanism
2022-08-24 11:02:11 +02:00
Molkobain
c8cb64db24
N°4739 - Remove precompiled themes unit test as they are no longer used since the introduction of DM classes style SCSS
2022-08-16 11:48:38 +02:00
Pierre Goiffon
f0d1c3ac60
Merge remote-tracking branch 'origin/support/2.7' into support/3.0
...
# Conflicts:
# application/utils.inc.php
# core/htmlsanitizer.class.inc.php
# datamodels/2.x/itop-portal-base/portal/src/Twig/AppExtension.php
# pages/UI.php
# test/OQL/DataLocalizerTest.php
# test/OQL/OQLToSQLAllClassesTest.php
# test/OQL/OQLToSQLGroupByTest.php
# test/OQL/OQLToSQLNestedSelectTest.php
# test/OQL/OQLToSQLTest.php
# test/application/UtilsTest.php
2022-05-24 11:13:28 +02:00
Pierre Goiffon
f57d1f1de3
✅ Fix PHPunit errors with InlineImageMock.php and UtilsTest
...
HTMLDOMSanitizerTest : fix "Fatal error: Cannot declare class InlineImage, because the name is already in use in /var/www/html/iTop/test/core/sanitizer/InlineImageMock.php"
We are now injecting the class to mock, instead of declaring another class with the same name (was working before but why ?!???)
\UtilsTest::testSanitizer : no more testing the "class" filter, because it is a simple indirection, and we need to load datamodel which is causing multiple problems (see the comment in the test method dataprovider)
2022-05-20 10:48:05 +02:00
Benjamin Dalsass
03ef4246bf
N°4899 - add sanitizer url since annotation and tests for sanitizer function
2022-05-18 12:03:07 +02:00
Molkobain
ff58fb8617
N°5172 - Add internal helpers to keep usage of null value in native PHP methods: strlen() => utils::StrLen()
2022-05-16 16:15:18 +02:00
Pierre Goiffon
5a37bc338a
N°3091 Update PHPUnit to 8.5 : fix setUp and teardDown methods signatures on support/3.0 new tests
2022-04-22 16:04:54 +02:00
Pierre Goiffon
f4a027b474
Merge remote-tracking branch 'origin/support/2.7' into support/3.0
...
# Conflicts:
# composer.json
# core/cmdbchangeop.class.inc.php
# core/cmdbobject.class.inc.php
# css/light-grey.scss
# setup/setuputils.class.inc.php
# test/ItopTestCase.php
# test/core/ConfigTest.php
# test/core/LogAPITest.php
# test/core/UserRightsTest.php
# test/core/dictApcuTest.php
# test/core/dictTest.php
# test/core/iTopConfigParserTest.php
# test/core/ormLinkSetTest.php
# test/phpunit.xml.dist
# test/postbuild_integration.xml.dist
# test/setup/SetupUtilsTest.php
# test/status/StatusIncTest.php
# webservices/cron.php
2022-04-22 15:26:18 +02:00
Pierre Goiffon
d0ba0d193b
N°3091 iTopComposerTest : change deprecated PHPUnit method call
2022-04-22 14:42:12 +02:00
Pierre Goiffon
ec143c43db
N°3091 Update PHPUnit to 8.5 : fix setUp and teardDown methods signatures
...
"Return type declaration must be compatible with parent"
See https://phpunit.de/announcements/phpunit-8.html "Return Type of Template Methods"
2022-04-21 12:02:35 +02:00
Molkobain
cd7f9e478f
N°4913 - Avoid object initials to overflow in medallions
2022-03-06 22:44:12 +01:00
Molkobain
e3586cff65
Unit tests: Add unit cyrillic alphabet test case for utils::ToAcronym()
2022-03-06 16:31:48 +01:00
Pierre Goiffon
6a5840ed82
Merge remote-tracking branch 'origin/support/2.7' into support/3.0
...
# Conflicts:
# lib/composer/installed.php
# setup/licenses/community-licenses.xml
# setup/setuputils.class.inc.php
# sources/application/TwigBase/Controller/Controller.php
2022-02-14 08:41:33 +01:00
Pierre Goiffon
81c39c35cd
N°4771 Fix lib test dir detection
...
Thanks to @Molkobain and @Hipska for their review in dfaa9733
2022-02-11 18:15:56 +01:00
Pierre Goiffon
dfaa973359
N°4771 improve iTopComposerTest
...
- debug testListDeniedTestDir not working well on Windows
- update error message for testAllDirCovered
2022-02-10 12:54:09 +01:00
Pierre Goiffon
3a4c4cd33d
N°4624 Fix SessionTest
2022-01-10 16:50:02 +01:00
Pierre Goiffon
9aa399894c
N°4624 Add processIsolation PHPUnit option to all tests implementing ItopDataTestCase
2022-01-10 16:41:26 +01:00
Pierre Goiffon
8578d18e7f
Merge remote-tracking branch 'origin/support/2.7' into support/3.0
...
# Conflicts:
# core/cmdbsource.class.inc.php
# core/config.class.inc.php
# core/displayablegraph.class.inc.php
# core/log.class.inc.php
# datamodels/2.x/itop-config-mgmt/dictionaries/tr.dict.itop-config-mgmt.php
# datamodels/2.x/itop-knownerror-mgmt/dictionaries/tr.dict.itop-knownerror-mgmt.php
# datamodels/2.x/itop-service-mgmt/dictionaries/tr.dict.itop-service-mgmt.php
# datamodels/2.x/itop-tickets/tr.dict.itop-tickets.php
# datamodels/2.x/itop-welcome-itil/tr.dict.itop-welcome-itil.php
# dictionaries/tr.dictionary.itop.core.php
# dictionaries/tr.dictionary.itop.ui.php
# pages/UI.php
# setup/itopdesignformat.class.inc.php
# test/core/LogAPITest.php
# test/integration/iTopModulesPhpVersionChecklistTest.php
# test/postbuild_integration/SetupCssIntegrityChecklistTest.php
# test/postbuild_integration/iTopModuleXmlInstallationChecklistTest.php
# test/status/StatusTest.php
2022-01-10 16:15:00 +01:00
Pierre Goiffon
ddb8378fe6
N°4624 align phpunit annotations
...
Remove processIsolation when not needed
When needed, make sure to have also their counterpart (preserveGlobalState and backupGlobals)
2022-01-07 15:20:34 +01:00
Molkobain
5f382ee053
Fix ThemeHandlerTest for file imports in a module
2021-12-20 15:56:58 +01:00
Pierre Goiffon
c9ef543e2e
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# core/log.class.inc.php
# datamodels/2.x/itop-attachments/renderers.itop-attachments.php
# js/search/search_form_criteria_enum.js
# lib/composer/autoload_classmap.php
# lib/composer/autoload_static.php
# test/core/dictTest.php
2021-12-08 18:30:20 +01:00
Pierre Goiffon
e6d61d1ebd
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
2021-12-08 17:16:33 +01:00
Pierre Goiffon
f916f9cde8
N°4289 Allow to use privUITransactionFile when no user logged
...
Before we were throwing a SecurityException, which was blocking for combodo-unauthenticated-form for example
2021-12-08 17:16:12 +01:00
odain
07f470024a
N°4367 : renamed the phpunit annotation for ci purpose
2021-11-09 08:55:54 +01:00
odain
a286564345
N°4367 : add phpunit annotation for ci
2021-11-08 06:42:45 +01:00
Pierre Goiffon
456283866c
✏️ Fix typo in code comment
2021-11-05 11:24:18 +01:00
Pierre Goiffon
2e8920f3d1
✅ N°4367 Fix \privUITransactionFileTest::testIsTransactionValid
...
Was crashing because of limitations on loading User objects
2021-11-04 16:15:01 +01:00
Pierre Goiffon
2d44d9d1c6
N°4367 disable test for now
...
On develop we have an error on Jenkins :
> Login with user2 throw an error
2021-11-03 15:19:42 +01:00
Pierre Goiffon
04f7660267
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# js/utils.js
2021-11-03 11:19:23 +01:00
Pierre Goiffon
8c7f7abaab
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
...
# Conflicts:
# test/application/privUITransactionFileTest.php
2021-11-03 11:10:43 +01:00
Pierre Goiffon
e8d314e1f6
✅ N°4367 Fix \privUITransactionFileTest::testIsTransactionValid
...
* change user name for when password policy is active
* admin user doesn't exist on Jenkins : create a second user
* test UserRights::Login return value
* document that we depend on the sample data
2021-11-03 10:50:25 +01:00
Pierre Goiffon
ed43d00afe
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# application/transaction.class.inc.php
# core/userrights.class.inc.php
2021-10-21 15:12:23 +02:00
Pierre Goiffon
908a48e0a1
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
...
# Conflicts:
# application/transaction.class.inc.php
# test/application/privUITransactionFileTest.php
2021-10-21 15:09:50 +02:00
Pierre Goiffon
9b854dbcc7
N°4289 skip test (not working on Jenkins)
2021-10-21 14:52:59 +02:00
Pierre Goiffon
7757f1f2d2
N°4289 Security hardening
2021-10-21 12:43:03 +02:00
Molkobain
75d913a003
Compiler: Factorize DM classes style and add them to the DM CSS rules
2021-09-25 23:51:52 +02:00
Molkobain
7404599721
N°3882 - Fix unit tests
2021-09-23 14:16:22 +02:00
Molkobain
99026cec1f
N°3882 - Compiler: Prepare unit test for DM CSS rules (needs to be completed with the team)
2021-09-23 11:44:12 +02:00
Eric
2c2155a8e0
N°3985 - Performance checks on the back end
2021-08-23 13:57:03 +02:00
Pierre Goiffon
bd67b71f3d
Merge remote-tracking branch 'origin/support/2.7' into develop
2021-07-06 11:36:34 +02:00
Pierre Goiffon
e32e275f40
🎨 Align dataprovider elements
2021-06-29 16:45:34 +02:00
Pierre Goiffon
aa9ab1ace5
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# css/css-variables.scss
# datamodels/2.x/authent-cas/module.authent-cas.php
# datamodels/2.x/authent-external/module.authent-external.php
# datamodels/2.x/authent-ldap/module.authent-ldap.php
# datamodels/2.x/authent-local/module.authent-local.php
# datamodels/2.x/combodo-db-tools/module.combodo-db-tools.php
# datamodels/2.x/itop-attachments/module.itop-attachments.php
# datamodels/2.x/itop-backup/module.itop-backup.php
# datamodels/2.x/itop-bridge-virtualization-storage/module.itop-bridge-virtualization-storage.php
# datamodels/2.x/itop-change-mgmt-itil/module.itop-change-mgmt-itil.php
# datamodels/2.x/itop-change-mgmt/module.itop-change-mgmt.php
# datamodels/2.x/itop-config-mgmt/module.itop-config-mgmt.php
# datamodels/2.x/itop-config/module.itop-config.php
# datamodels/2.x/itop-core-update/module.itop-core-update.php
# datamodels/2.x/itop-datacenter-mgmt/module.itop-datacenter-mgmt.php
# datamodels/2.x/itop-endusers-devices/module.itop-endusers-devices.php
# datamodels/2.x/itop-files-information/module.itop-files-information.php
# datamodels/2.x/itop-full-itil/module.itop-full-itil.php
# datamodels/2.x/itop-hub-connector/module.itop-hub-connector.php
# datamodels/2.x/itop-incident-mgmt-itil/module.itop-incident-mgmt-itil.php
# datamodels/2.x/itop-knownerror-mgmt/module.itop-knownerror-mgmt.php
# datamodels/2.x/itop-portal-base/module.itop-portal-base.php
# datamodels/2.x/itop-portal/module.itop-portal.php
# datamodels/2.x/itop-problem-mgmt/module.itop-problem-mgmt.php
# datamodels/2.x/itop-profiles-itil/module.itop-profiles-itil.php
# datamodels/2.x/itop-request-mgmt-itil/module.itop-request-mgmt-itil.php
# datamodels/2.x/itop-request-mgmt/module.itop-request-mgmt.php
# datamodels/2.x/itop-service-mgmt-provider/module.itop-service-mgmt-provider.php
# datamodels/2.x/itop-service-mgmt/module.itop-service-mgmt.php
# datamodels/2.x/itop-sla-computation/module.itop-sla-computation.php
# datamodels/2.x/itop-storage-mgmt/module.itop-storage-mgmt.php
# datamodels/2.x/itop-tickets/module.itop-tickets.php
# datamodels/2.x/itop-virtualization-mgmt/module.itop-virtualization-mgmt.php
# datamodels/2.x/itop-welcome-itil/module.itop-welcome-itil.php
# datamodels/2.x/version.xml
2021-06-29 16:12:49 +02:00
Pierre Goiffon
b5074c4cee
N°3806 Fix saying memory_limit isn't enough in CLI scripts and setup
...
This was caused by the strict comparison in \utils::IsMemoryLimitOk for the special "-1" value of memory_limit, which was added in c2f5cafa .
Fix was to change \utils::ConvertToBytes : it was returning original value when input was numeric (so if input is '-1' output was '-1') now it always returns an int (input '-1' output -1)
2021-06-28 14:53:39 +02:00
odain
4d123e1450
fix ci
2021-06-22 10:00:18 +02:00
Pierre Goiffon
d8e2a1cc7c
Merge branch 'support/2.7' into develop
...
# Conflicts:
# README.md
# composer.json
# composer.lock
# core/cmdbsource.class.inc.php
# core/dbobject.class.php
# datamodels/2.x/combodo-db-tools/db_analyzer.class.inc.php
# datamodels/2.x/combodo-db-tools/dbtools.php
# datamodels/2.x/combodo-db-tools/dictionaries/zh_cn.dict.combodo-db-tools.php
# datamodels/2.x/itop-attachments/dictionaries/zh_cn.dict.itop-attachments.php
# datamodels/2.x/itop-core-update/dictionaries/zh_cn.dict.itop-core-update.php
# dictionaries/zh_cn.dictionary.itop.core.php
# dictionaries/zh_cn.dictionary.itop.ui.php
# lib/composer/InstalledVersions.php
# lib/composer/autoload_classmap.php
# lib/composer/autoload_static.php
# lib/composer/installed.php
# lib/composer/platform_check.php
# pages/ajax.render.php
# pages/csvimport.php
# setup/ajax.dataloader.php
# setup/index.php
# setup/setuputils.class.inc.php
# test/application/UtilsTest.php
2021-06-14 16:19:56 +02:00
Pierre Goiffon
44952d1ea0
✅ Fix \UtilsTest::testIsMemoryLimit
2021-05-25 17:04:32 +02:00
BGdu38
c2f5cafaf3
Avoid setting memory_limit to lower value than the one already configured ( #215 )
...
Some scripts are setting the memory_limit PHP option : setup, csvimport and XLSX export. This was done to avoid crashing when dealing with such large amount of data.
But sometimes we were setting the value without any prior check, so we could actually lower the memory_limit value :/
Now this memory_limit change is done using \utils::SetMinMemoryLimit, which will call ini_set if and only if the current value is lower than the one to be set.
Setup calls (setup/ajax.dataloader.php and webservices/backoffice.dataloader.php) were left as is as they weren't subject to this bug, and also they are more complex (logging done on each case).
2021-05-25 12:03:19 +02:00
Molkobain
7aecdd0dc7
N°2875 - Extract method to find mentioned objects into utils so it can used by extensions, not only the trigger
2021-04-23 17:01:17 +02:00
odain
3b3fa7b1f8
N°2982 - rename imports_utility and imports_variable in precompilation signature
2021-04-16 11:56:16 +02:00
odain
beadd9cd03
N°3593 - GetVariablesFromFile and precompilation signature fixes + tests
2021-04-13 23:42:53 +02:00