composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-21 09:38:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

✅ N°4367 Fix \privUITransactionFileTest::testIsTransactionValid

Browse Source 
Was crashing because of limitations on loading User objects
This commit is contained in:
Pierre Goiffon
2021-11-04 16:15:01 +01:00
parent 4450c28295
commit 2e8920f3d1
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/application/privUITransactionFileTest.php
View File

@@ -148,11 +148,15 @@ class privUITransactionFileTest extends ItopDataTestCase
*/
public function testIsTransactionValid()
{
$this->markTestSkipped('on Jenkins, develop branch we have "Login with user2 throw an error"');
$this->CreateUser(static::USER1_TEST_LOGIN, self::SAMPLE_DATA_SUPPORT_PROFILE_ID);
$this->CreateUser(static::USER2_TEST_LOGIN, self::SAMPLE_DATA_SUPPORT_PROFILE_ID);
// created users aren't admin, so each one can't see the other (\UserRights::GetSelectFilter)
// If calling \UserRights::Login(user1) then \UserRights::Login(user2) we won't be able to load user2 !
// As now we are in the admin context, we are calling FindUser() directly so that user objects will be saved in the UserRights cache !
// user1 can be omitted as the first \UserRights::Login cache will initialize the UserRights cache
$this->InvokeNonPublicStaticMethod(UserRights::class, 'FindUser', [self::USER2_TEST_LOGIN]);
// create token in the user1 context
$bUser1Login1 = UserRights::Login(self::USER1_TEST_LOGIN);
$this->assertTrue($bUser1Login1, 'Login with user1 throw an error');