composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-03-04 16:44:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix ContextTag usage, and add some explanations on the declaration of ContextTag

Browse Source
This commit is contained in:
Eric
2021-02-26 16:47:02 +01:00
parent 925e45782c
commit fb321fa034
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/contexttag.class.inc.php
View File

@@ -20,6 +20,24 @@
/**
* Simple helper class for keeping track of the context inside the call stack
*
* Beware:
* As the destructor removes the last context, don't use the same variable if you want to keep your context.
* $oCtx = new ContextTag("Tag1");
* $oCtx = new ContextTag("Tag2"); // Bad the destructor will remove "Tag2"
* $oCtx = new ContextTag("Tag3"); // Bad the destructor will remove "Tag3"
*
* Instead, use separate variables:
* $oCtx1 = new ContextTag("Tag1");
* $oCtx2 = new ContextTag("Tag2");
* $oCtx3 = new ContextTag("Tag3");
*
* And don't forget that any destructor (of $oCtx1, $oCtx2 or $oCtx3) will remove the LAST added tag ("Tag3" in our example)
*
* If you want to declare permanent contexts (request lifetime) you should use:
* ContextTag::AddContext("Tag1");
* ContextTag::AddContext("Tag2");
* ContextTag::AddContext("Tag3");
*
* To check (anywhere in the code) if a particular context tag is present
* in the call stack simply do:
*

4
datamodels/2.x/itop-core-update/ajax.php
View File

@@ -23,7 +23,7 @@ require_once(MODULESROOT.'itop-core-update/src/Controller/AjaxController.php');
MetaModel::LoadConfig(utils::GetConfig());
new ContextTag(ContextTag::TAG_SETUP);
$oCtxCoreUpdate = new ContextTag(ContextTag::TAG_SETUP);
$oUpdateController = new AjaxController(MODULESROOT.'itop-core-update/view', 'itop-core-update');
$oUpdateController->DisableInDemoMode();
@@ -32,3 +32,5 @@ $oUpdateController->AllowOnlyAdmin();
// Allow parallel execution of ajax requests
session_write_close();
$oUpdateController->HandleAjaxOperation();
unset($oCtxCoreUpdate);