composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-09 10:28:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

✅ Fix CI (To be checked) by simplifying mocks

Browse Source
This commit is contained in:
Eric Espie
2026-04-17 10:41:54 +02:00
parent 999e4de7f1
commit f05d98aba8
1 changed files with 13 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/php-unit-tests/unitary-tests/setup/sequencers/ApplicationInstallerSequencerTest.php
View File

@@ -11,7 +11,6 @@ use RunTimeEnvironment;
class ApplicationInstallerSequencerTest extends ItopTestCase
{
private \RunTimeEnvironment&\PHPUnit\Framework\MockObject\MockObject $oRunTimeEnvironment;
private \Config&\PHPUnit\Framework\MockObject\MockObject $oConfig;
private ApplicationInstallSequencer $oSequencer;
protected function setUp(): void
@@ -25,6 +24,9 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
$this->RequireOnceItopFile('/setup/parameters.class.inc.php');
$this->RequireOnceItopFile('/setup/setuputils.class.inc.php');
$this->RequireOnceItopFile('/setup/runtimeenv.class.inc.php');
// Copy conf to production-test
\SetupUtils::copydir(APPROOT.'conf/production', APPROOT.'conf/production-test');
}
public static function FirstStepProvider()
@@ -139,8 +141,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('Backup')
->with($this->oConfig, '/my_backup_file_path', '/my_config_file_path', null);
$this->oRunTimeEnvironment->expects($this->once())->method('Backup');
$aRes = $this->oSequencer->ExecuteStep('backup');
$aExpected = [
@@ -162,8 +163,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('MigrateDataBeforeUpdateStructure')
->with('install', $this->oConfig);
$this->oRunTimeEnvironment->expects($this->once())->method('MigrateDataBeforeUpdateStructure');
$aRes = $this->oSequencer->ExecuteStep('migrate-before');
$aExpected = [
@@ -207,8 +207,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('UpdateDBSchema')
->with($this->oConfig, 'install', ["a" => "b"]);
$this->oRunTimeEnvironment->expects($this->once())->method('UpdateDBSchema');
$this->oRunTimeEnvironment->expects($this->once())->method('SetDbUUID')
->with();
@@ -232,8 +231,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('MigrateDataAfterUpdateStructure')
->with('install', $this->oConfig);
$this->oRunTimeEnvironment->expects($this->once())->method('MigrateDataAfterUpdateStructure');
$aRes = $this->oSequencer->ExecuteStep('migrate-after');
$aExpected = [
@@ -259,8 +257,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('AfterDBCreate')
->with($this->oConfig, 'install', ["a" => "b"], $aAdminParams);
$this->oRunTimeEnvironment->expects($this->once())->method('AfterDBCreate');
$aRes = $this->oSequencer->ExecuteStep('after-db-create');
$aExpected = [
@@ -281,8 +278,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('DoLoadData')
->with($this->oConfig, true, ["a" => "b"]);
$this->oRunTimeEnvironment->expects($this->once())->method('DoLoadData');
$aRes = $this->oSequencer->ExecuteStep('load-data');
$aExpected = [
@@ -304,8 +300,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
'sample_data' => 1,
];
$this->GivenApplicationInstallSequencer($aAdditionalParams);
$this->oRunTimeEnvironment->expects($this->once())->method('DoCreateConfig')
->with($this->oConfig, "6.6.6", ["a" => "b"], ["c" => "d"], null);
$this->oRunTimeEnvironment->expects($this->once())->method('DoCreateConfig');
$aRes = $this->oSequencer->ExecuteStep('create-config');
$aExpected = [
@@ -338,7 +333,7 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
public function testAnyFailure()
{
$this->GivenApplicationInstallSequencer();
$this->oRunTimeEnvironment->expects($this->once())->method('GetBuildEnv')
$this->oRunTimeEnvironment->expects($this->once())->method('UpdateDBSchema')
->willThrowException(new \CoreException('SHADOK MSG'));
$aRes = $this->oSequencer->ExecuteStep('db-schema');
@@ -488,21 +483,14 @@ class ApplicationInstallerSequencerTest extends ItopTestCase
{
$this->oRunTimeEnvironment = $this->createMock(RunTimeEnvironment::class);
if (! $bStepComputationOnly) {
$this->oRunTimeEnvironment->expects($this->once())->method('EnterReadOnlyMode')
->with($this->oConfig);
$this->oRunTimeEnvironment->expects($this->once())->method('EnterReadOnlyMode');
$this->oRunTimeEnvironment->expects($this->any())->method('GetBuildEnv')->willReturn('production-test');
}
}
private function GivenConfig(): void
{
$this->oConfig = $this->createMock(Config::class);
}
private function GivenApplicationInstallSequencer(array $aAdditionalParams = [], bool $bStepComputationOnly = false): void
{
$this->GivenConfig();
$this->GivenRunTimeEnvironment($bStepComputationOnly);
$this->oSequencer = new ApplicationInstallSequencer($this->GivenParams($aAdditionalParams), $this->oRunTimeEnvironment);
$this->SetNonPublicProperty($this->oSequencer, 'oConfig', $this->oConfig);
}
}