composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-22 01:58:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Internal: AttributeDateTime column changed from TIMESTAMP to DATETIME (issues with some bulk imports)

Browse Source 
SVN:trunk[2287]
This commit is contained in:
Romain Quetiez
2012-10-18 09:50:39 +00:00
parent ed15cde281
commit e938dfb5c9
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/attributedef.class.inc.php
View File

@@ -2378,7 +2378,8 @@ class AttributeDateTime extends AttributeDBField
}
public function GetEditClass() {return "DateTime";}
protected function GetSQLCol() {return "TIMESTAMP";}
protected function GetSQLCol() {return "DATETIME";}
public static function GetAsUnixSeconds($value)
{
$oDeadlineDateTime = new DateTime($value);
@@ -2386,13 +2387,8 @@ class AttributeDateTime extends AttributeDBField
return $iUnixSeconds;
}
// #@# THIS HAS TO REVISED
// Having null not allowed was interpreted by mySQL
// which was creating the field with the flag 'ON UPDATE CURRENT_TIMESTAMP'
// Then, on each update of the record, the field was modified.
// We will have to specify the default value if we want to restore this option
// In fact, we could also have more verbs dedicated to the DB:
// GetDBDefaultValue()... or GetDBFieldCreationStatement()....
// This has been done at the time when itop was using TIMESTAMP columns,
// now that iTop is using DATETIME columns, it seems possible to have IsNullAllowed returning false... later when this is needed
public function IsNullAllowed() {return true;}
public function GetDefaultValue()
{