composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°4756 - restrict readonly mode to events only for CheckToWrite (keep legacy calls unprotected)

Browse Source
This commit is contained in:
Eric Espie
2022-10-31 12:15:52 +01:00
parent fcdfd54066
commit e70e9de1c8
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/dbobject.class.php
View File

@@ -2339,7 +2339,7 @@ abstract class DBObject implements iDisplay
* @throws \OQLException
*
*/
public function CheckToWrite($bDoComputeValues = true)
public final function CheckToWrite($bDoComputeValues = true)
{
if (MetaModel::SkipCheckToWrite())
{
@@ -2353,8 +2353,11 @@ abstract class DBObject implements iDisplay
if ($bDoComputeValues) {
$this->DoComputeValues();
}
// Event before the legacy callback
$this->SetReadOnly('No modification allowed during CheckToWrite');
$this->EventCheckToWrite(['error_messages' => &$this->m_aCheckIssues]);
$this->SetReadWrite();
$this->DoCheckToWrite();
$oKPI->ComputeStats('CheckToWrite', get_class($this));
if (count($this->m_aCheckIssues) == 0)
@@ -2980,9 +2983,7 @@ abstract class DBObject implements iDisplay
}
// Ultimate check - ensure DB integrity
$this->SetReadOnly('No modification allowed during CheckToWrite');
list($bRes, $aIssues) = $this->CheckToWrite(false);
$this->SetReadWrite();
if (!$bRes) {
throw new CoreCannotSaveObjectException(array('issues' => $aIssues, 'class' => get_class($this), 'id' => $this->GetKey()));
}