composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-22 18:18:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°5920 - Tab manager: Fallback on dict entry code convention (tab code followed by "+" sign) for tab's description / tooltip if none given

Browse Source
This commit is contained in:
Molkobain
2023-02-08 18:22:49 +01:00
parent 86a208a86d
commit d358c9e8fa
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
sources/Application/WebPage/TabManager.php
View File

@@ -342,16 +342,29 @@ class TabManager
$oTabContainer = $this->m_aTabs[$sTabContainer];
}
// For title, if none given, try to fallback on a dict entry by convention (dict entry code = tab code)
$sTitle = ($sTabTitle !== null) ? Dict::S($sTabTitle) : Dict::S($sTabCode);
// For description, if none given, try to fallback on a dict entry by convention (dict entry code = tab code followed by a "+" sign) but only if an entry exists, otherwise it would display a tooltip with a dict entry code which is not slick (eg. "Tab:Title:Foo+")
$sDescription = null;
if ($sTabDescription !== null) {
$sDescription = Dict::S($sTabDescription);
} else {
$sFallbackDescriptionDictEntryCode = $sTabCode."+";
$sFallbackDescription = Dict::S($sFallbackDescriptionDictEntryCode);
if ($sFallbackDescriptionDictEntryCode !== $sFallbackDescription) {
$sDescription = $sFallbackDescription;
}
}
switch ($sTabType) {
case static::ENUM_TAB_TYPE_AJAX:
$oTab = $oTabContainer->AddAjaxTab($sTabCode, $sTitle, $sPlaceholder, $sTabDescription);
$oTab = $oTabContainer->AddAjaxTab($sTabCode, $sTitle, $sPlaceholder, $sDescription);
break;
case static::ENUM_TAB_TYPE_HTML:
default:
$oTab = $oTabContainer->AddTab($sTabCode, $sTitle, $sTabDescription);
$oTab = $oTabContainer->AddTab($sTabCode, $sTitle, $sDescription);
break;
}
} else {