composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°5779 update-xml : update code using iterators

Browse Source
This commit is contained in:
Pierre Goiffon
2022-12-12 09:28:42 +01:00
parent e4e654100e
commit c2f503e2ac
1 changed files with 59 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
test/.make/release/DatamodelsXmlFilesTest.php
View File

@@ -46,64 +46,72 @@ class DatamodelsXmlFilesTest extends ItopTestCase
$iterator = new RecursiveIteratorIterator(
$oDirectoryIterator,
RecursiveIteratorIterator::CHILD_FIRST);
$aITopDesignFilesFromDisk = [];
$aDirectoriesToExclude = $this->GetAllDirectoriesToIgnoreForITopDesignFilesSearch();
$aDirectoriesToExclude = array_map(function ($value) {
$sRawDir = APPROOT.$value;
return str_replace('\\', '/', $sRawDir);
}, $aDirectoriesToExclude);
/** @var DirectoryIterator $file */
foreach ($iterator as $file) {
if ($file->isDir()) {
continue;
}
$sFilePath = str_replace('\\', '/', $file->getPathname());
if (substr($sFilePath, -4) !== '.xml') {
continue;
}
$bIsPartOfADirToExclude = false;
foreach ($aDirectoriesToExclude as $sDirToExclude) {
if (strpos($sFilePath, $sDirToExclude) === 0) {
$bIsPartOfADirToExclude = true;
break;
}
}
if ($bIsPartOfADirToExclude) {
continue;
}
if (false === $this->IsITopDesignFile($sFilePath)) {
continue;
}
$aITopDesignFilesFromDisk[] = $sFilePath;
}
$oITopDesignIterator = new ITopDesignFilter($iterator);
$aITopDesignFilesFromDisk = iterator_to_array($oITopDesignIterator);
$aITopDesignFilesFromDisk = array_map(function ($file) {
return str_replace('\\', '/', $file->getPathname());
}, $aITopDesignFilesFromDisk);
sort($aITopDesignFilesFromScript);
sort($aITopDesignFilesFromDisk);
$this->assertEquals($aITopDesignFilesFromDisk, $aITopDesignFilesFromScript, 'The XML files update script is not targeting some iTop design files ! '.DatamodelsXmlFiles::class.' must be updated !');
}
}
private function GetAllDirectoriesToIgnoreForITopDesignFilesSearch(): array
class ITopDesignFilter extends FilterIterator
{
const DIRECTORIES_TO_EXCLUDE = [
// iTop repo excluded dirs
'.doc',
'.git',
'.idea',
'data/', // trailing slash to avoid confusion with datamodels dir
'env-',
'extensions',
'test',
// clones specificities
'toolkit',
'toolkit-pro',
'.delta',
'.hacks',
];
private $aDirToExcludeFullPath;
public function __construct($iterator)
{
return [
// iTop repo excluded dirs
'.doc',
'data/', // trailing slash to avoid confusion with datamodels dir
'env-',
'extensions',
'test',
parent::__construct($iterator);
// clones specificities
'toolkit',
'toolkit-pro',
'.delta',
'.hacks',
];
$this->aDirToExcludeFullPath = array_map(function ($value) {
$sRawDir = APPROOT.$value;
return str_replace('\\', '/', $sRawDir);
}, self::DIRECTORIES_TO_EXCLUDE);
}
public function accept()
{
$file = $this->current();
if ($file->isDir()) {
return false;
}
$sFilePath = str_replace('\\', '/', $file->getPathname());
if (substr($sFilePath, -4) !== '.xml') {
return false;
}
foreach ($this->aDirToExcludeFullPath as $sDirToExclude) {
if (strpos($sFilePath, $sDirToExclude) === 0) {
return false;
}
}
if (false === $this->IsITopDesignFile($sFilePath)) {
return false;
}
return true;
}
private function IsITopDesignFile($sFilePath)
@@ -131,4 +139,4 @@ class DatamodelsXmlFilesTest extends ItopTestCase
return true;
}
}
}