N°6933 - SF 6.4 - Remove deprecated calls

- CreateBrickController (services access)

datamodels/2.x/itop-portal-base/portal/src/Controller/CreateBrickController.php

@@ -20,8 +20,10 @@
 
 namespace Combodo\iTop\Portal\Controller;
 
+use Combodo\iTop\Portal\Brick\BrickCollection;
 use Combodo\iTop\Portal\Helper\ContextManipulatorHelper;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 /**
  * Class CreateBrickController
@@ -33,27 +35,29 @@ use Symfony\Component\HttpFoundation\Request;
 class CreateBrickController extends BrickController
 {
 
+	/**
+	 * Constructor.
+	 *
+	 * @param \Combodo\iTop\Portal\Brick\BrickCollection $oBrickCollection
+	 */
+	public function __construct(
+		protected BrickCollection $oBrickCollection
+	)
+	{
+	}
+
 	/**
 	 * @param \Symfony\Component\HttpFoundation\Request $oRequest
 	 * @param string                                    $sBrickId
 	 *
 	 * @return \Symfony\Component\HttpFoundation\Response
 	 *
-	 * @throws \CoreException
-	 * @throws \DictExceptionMissingString
-	 * @throws \MissingQueryArgument
-	 * @throws \MySQLException
-	 * @throws \MySQLHasGoneAwayException
-	 * @throws \OQLException
 	 * @throws \Combodo\iTop\Portal\Brick\BrickNotFoundException
 	 */
-	public function DisplayAction(Request $oRequest, $sBrickId)
+	public function DisplayAction(Request $oRequest, $sBrickId) : Response
 	{
-		/** @var \Combodo\iTop\Portal\Brick\BrickCollection $oBrickCollection */
-		$oBrickCollection = $this->get('brick_collection');
-
 		/** @var \Combodo\iTop\Portal\Brick\CreateBrick $oBrick */
-		$oBrick = $oBrickCollection->GetBrickById($sBrickId);
+		$oBrick = $this->oBrickCollection->GetBrickById($sBrickId);
 
 		$aRouteParams = array(
 			'sBrickId' => $sBrickId,