composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°2192 table-selectable-lines : replace another :has selector, and use existing constant

Browse Source
This commit is contained in:
Pierre Goiffon
2019-05-07 11:44:41 +02:00
parent 3c4fe338b6
commit b1ff7f0e9b
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
js/table-selectable-lines.js
View File

@@ -59,7 +59,7 @@ $(document).ready(function () {
$lineClickedInput.click();
});
$(document).on('change', 'table.listResults', function (event) {
$(document).on('change', TABLE_SELECTOR, function (event) {
var $eventTarget = $(event.target);
if (!$eventTarget.has(LINE_WITH_INPUT_IN_FIRST_CELL_SELECTOR))
// Originally we had :has in the handler selector but performances were very bad :(
@@ -75,7 +75,14 @@ $(document).ready(function () {
});
// check_all event is fired for tableSorter JQuery plugin
$(document).on("check_all", TABLE_SELECTOR+':has('+LINE_WITH_INPUT_IN_FIRST_CELL_SELECTOR+')', function () {
$(document).on("check_all", TABLE_SELECTOR, function () {
var $eventTarget = $(event.target);
if (!$eventTarget.has(LINE_WITH_INPUT_IN_FIRST_CELL_SELECTOR))
// Originally we had :has in the handler selector but performances were very bad :(
// Filtering directly in JQuery is far much quicker ! => N°2192
{
return;
}
$(this).find("tbody>tr").addClass(SELECTED_CLASS);
});