composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-17 06:18:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

PHPUnit: Migrate deprecated usages of assertFileNotExists() and assertRegExp()

Browse Source
This commit is contained in:
Molkobain
2023-02-24 21:41:53 +01:00
parent 029c01b13e
commit b1bd1e1677
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/php-unit-tests/unitary-tests/core/Log/LogFileNameBuilderTest.php
View File

@@ -70,7 +70,7 @@ class LogFileNameBuilderTest extends ItopTestCase
$sRotatedLogFile = $oFileBuilder->GetRotatedFileName($oLogFileLastModified);
$oFileBuilder->CheckAndRotateLogFile();
$this->assertFileExists($sLogFile, 'Test log file modification date is today, original file still exists after rotation call');
$this->assertFileNotExists($sRotatedLogFile, 'No rotation occurred yet');
$this->assertFileDoesNotExist($sRotatedLogFile, 'No rotation occurred yet');
$oTimeYesterday = new DateTime('yesterday');
$sRotatedLogFile = $oFileBuilder->GetRotatedFileName($oTimeYesterday);
@@ -79,12 +79,12 @@ class LogFileNameBuilderTest extends ItopTestCase
// changing modification date, but do not reset cached filebuilder date => no change
$oFileBuilder->CheckAndRotateLogFile();
$this->assertFileExists($sLogFile, 'Test log file modification date is yesterday but filebuilder use its cache, original file still exists after rotation call');
$this->assertFileNotExists($sRotatedLogFile, 'No rotation occurred yet');
$this->assertFileDoesNotExist($sRotatedLogFile, 'No rotation occurred yet');
// changing modification date AND resetting filebuilder date cache
$oFileBuilder->ResetLastModifiedDateForFile();
$oFileBuilder->CheckAndRotateLogFile();
$this->assertFileNotExists($sLogFile, 'Test log file modification date is yesterday, file rotated !');
$this->assertFileDoesNotExist($sLogFile, 'Test log file modification date is yesterday, file rotated !');
$this->assertFileExists($sRotatedLogFile, 'Rotation was not done');
// file cleanup will be done in tearDown !

2
tests/php-unit-tests/unitary-tests/sources/Composer/iTopComposerTest.php
View File

@@ -71,7 +71,7 @@ class iTopComposerTest extends ItopTestCase
foreach ($aDirs as $sDir) {
$sDirName = basename($sDir);
$this->assertRegExp(iTopComposer::TEST_DIR_REGEXP, $sDirName, "Directory not matching test dir : $sDir");
$this->assertMatchesRegularExpression(iTopComposer::TEST_DIR_REGEXP, $sDirName, "Directory not matching test dir : $sDir");
}
}