composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-09 10:28:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°9144 - PR review feedbacks

Browse Source
This commit is contained in:
odain
2026-05-06 13:22:46 +02:00
parent f4a1aca3f9
commit ae1f9391f9
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
setup/runtimeenv.class.inc.php
View File

@@ -1566,7 +1566,9 @@ class RunTimeEnvironment
public function ExitMaintenanceMode(): void
{
SetupUtils::ExitMaintenanceMode();
if (SetupUtils::IsInMaintenanceMode()){
SetupUtils::ExitMaintenanceMode();
}
}
public function ExitReadOnlyMode()

8
tests/php-unit-tests/unitary-tests/setup/sequencers/DataAuditSequencerTest.php
View File

@@ -120,8 +120,8 @@ class DataAuditSequencerTest extends ItopTestCase
'status' => 1,
'message' => '',
'next-step' => 'complete',
'next-step-label' => 'Check Completed',
'percentage-completed' => 100,
'next-step-label' => 'Check Completed',
'percentage-completed' => 100,
];
$this->assertEquals($aExpected, $aRes);
}
@@ -328,9 +328,9 @@ class DataAuditSequencerTest extends ItopTestCase
public function testIsDataAuditRequired_NoAuditTriggeredBecauseDisabled()
{
$oRunTimeEnvironment = $this->createMock(\RunTimeEnvironment::class);
$oRunTimeEnvironment->expects($this->once())->method('GetApplicationVersion')
$oRunTimeEnvironment->expects($this->never())->method('GetApplicationVersion')
->willReturn(['product_version' => ITOP_VERSION_FULL]);
$oRunTimeEnvironment->expects($this->once())->method("GetFinalEnv")->willReturn("production");
$oRunTimeEnvironment->expects($this->never())->method("GetFinalEnv")->willReturn("production");
$aAdditionalParams = [
'mode' => 'upgrade',