composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

WIP

Browse Source
This commit is contained in:
jf-cbd
2025-02-27 17:26:14 +01:00
parent cb2a093498
commit a9e10742ec
2 changed files with 47 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
tests/php-unit-tests/unitary-tests/core/RestServicesTest.php
View File

@@ -21,11 +21,14 @@ namespace Combodo\iTop\Test\UnitTest\Core;
use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
use Combodo\iTop\Test\UnitTest\ItopTestCase;
use CoreException;
use CoreServices;
use UserRights;
use CoreUnexpectedValue;
use RestResultListOperations;
use SimpleGraphException;
class RestServicesTest extends ItopTestCase
class RestServicesTest extends ItopDataTestCase
{
public function setUp(): void
{
@@ -88,9 +91,23 @@ JSON;
$this->assertEquals($sExpectedJsonDataSanitized, $aJson['input_data'], $sOutputJson);
}
public function testOutputSanitization()
/**
* @param $sOperation
* @param $aJsonData
* @param $sExpectedJsonDataSanitized
* @return void
* @throws CoreException
* @throws CoreUnexpectedValue
* @throws SimpleGraphException
* @dataProvider providerTestSanitizeJsonOutput
*/
public function testSanitizeJsonOutput($sOperation, $aJsonData, $sExpectedJsonDataSanitized)
{
$oResult = new RestResultListOperations();
$oRS = new CoreServices();
$oResult = $oRS->ExecOperation('1.3', $sOperation, $aJsonData);
$oResult->SanitizeContent();
$this->assertEquals($sExpectedJsonDataSanitized, json_encode($oResult));
}
public function providerTestSanitizeJsonInput()
@@ -111,5 +128,29 @@ JSON;
];
}
public function providerTestSanitizeJsonOutput()
{
return [
'core/check_credentials' => [
'core/check_credentials',
['user' => 'admin', 'password' => 'admin'],
'{"operation":"core/check_credentials","user":"admin","password":"*****"}'
],
'core/update' => [
'core/update',
['comment' => 'Update user', 'class' => 'UserLocal', 'key' => ['description' => 'My description'], 'output_fields' => 'first_name, password', 'fields' => ['id' => '1', 'password' => '123456']],
'{"operation":"core/update","comment":"Update user","class":"UserLocal","key":{"description":"My description"},"output_fields":"first_name, password","fields":{"id":"1","password":"*****"}}'
],
'core/create' => [
'core/create',
['comment' => 'Create user', 'class' => 'UserLocal', 'fields' => ['first_name' => 'John', 'last_name' => 'Doe', 'email' => 'jd@example/com', 'password' => '123456']],
'{"operation":"core/create","comment":"Create user","class":"UserLocal","fields":{"first_name":"John","last_name":"Doe","email":"jd@example/com","password":"*****"}}'
],
'core/get' => [
'core/get',
['comment' => 'Get user', 'class' => 'UserLocal', 'key' => ['id' => '1'], 'output_fields' => 'first_name, password'],
'{"operation":"core/get","comment":"Get user","class":"UserLocal","key":{"id":"1"},"output_fields":"first_name, password"}'
],
];
}
}

1
webservices/rest.php
View File

@@ -241,6 +241,7 @@ catch(Exception $e)
//
$sResponse = json_encode($oResult);
if ($sResponse === false)
{
$oJsonIssue = new RestResult();