N°3537 Code review

Thanks @Molkobain !
This commit is contained in:
Pierre Goiffon
2020-12-16 08:06:53 +01:00
parent cb4fb15b0a
commit a20fd2278f
4 changed files with 33 additions and 6 deletions

View File

@@ -18,6 +18,7 @@
*/
use Combodo\iTop\Application\UI\Base\Component\Button\ButtonFactory;
use Combodo\iTop\Application\UI\Base\Component\Form\Form;
use Combodo\iTop\Application\UI\Base\Component\Html\Html;
use Combodo\iTop\Application\UI\Base\Component\Input\InputFactory;
@@ -153,7 +154,7 @@ try
}
}
$oQueryForm = new \Combodo\iTop\Application\UI\Base\Component\Form\Form();
$oQueryForm = new Form();
$oP->AddUiBlock($oQueryForm);
$oHiddenParams = new Html($oAppContext->GetForForm());

View File

@@ -24,7 +24,12 @@ class AbstractInput extends UIBlock
return $this->sName;
}
public function SetName(string $sName): AbstractInput
/**
* @param string $sName
*
* @return $this
*/
public function SetName(string $sName)
{
$this->sName = $sName;
@@ -36,7 +41,12 @@ class AbstractInput extends UIBlock
return $this->sValue;
}
public function SetValue(?string $sValue): AbstractInput
/**
* @param string|null $sValue
*
* @return $this
*/
public function SetValue(?string $sValue)
{
$this->sValue = $sValue;

View File

@@ -28,9 +28,15 @@ class Input extends AbstractInput
return $this->sType;
}
public function SetType(string $sType): Input
/**
* @param string $sType
*
* @return $this
*/
public function SetType(string $sType)
{
$this->sType = $sType;
return $this;
}
}

View File

@@ -35,7 +35,12 @@ class TextArea extends AbstractInput
return $this->iCols;
}
public function SetCols(int $iCols): TextArea
/**
* @param int $iCols
*
* @return $this
*/
public function SetCols(int $iCols)
{
$this->iCols = $iCols;
@@ -47,7 +52,12 @@ class TextArea extends AbstractInput
return $this->iRows;
}
public function SetRows(int $iRows): TextArea
/**
* @param int $iRows
*
* @return $this
*/
public function SetRows(int $iRows)
{
$this->iRows = $iRows;