composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-21 01:28:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°1002 Backup: '.' character in iTop instance path was causing a crash when trying to -temporary- replace them in the backup filename (due to compression lib limitations).

Browse Source 
SVN:trunk[4883]
This commit is contained in:
Guillaume Lajarige
2017-08-29 14:30:46 +00:00
parent c022d12a0a
commit 9cf42f6cc8
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
datamodels/2.x/itop-backup/ajax.backup.php
View File

@@ -182,4 +182,3 @@ catch (Exception $e)
IssueLog::Error($e->getMessage());
}
?>

6
setup/backup.class.inc.php
View File

@@ -282,10 +282,10 @@ if (class_exists('ZipArchive')) // The setup must be able to start even if the "
{
$this->LogInfo("Creating backup: '$sTargetFile.tar.gz'");
// Note: PharData::compress strips averything after the first dot found in the name of the tar, then it adds .tar.gz
// Note: PharData::compress strips everything after the first dot found in the name of the tar, then it adds .tar.gz
// Hence, we have to create our own file in the target directory, and rename it when the process is complete
$sTarFile = str_replace('.', '_', $sTargetFile).'.tar';
$this->LogInfo("Tar file: '$sTarFile'");
$sTarFile = dirname($sTargetFile) . '/' . str_replace('.', '_', basename($sTargetFile)) . '.tar';
$this->LogInfo("Tar file: '$sTarFile'");
$oArchive = new PharData($sTarFile);
// Note: the file is created by tempnam and might not be writeable by another process (Windows/IIS)