composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-27 06:04:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°3750 data-input-type Ajax refresh : use .attr() only

Browse Source 
This attributes value must be get using `.attr()` only, and never .data()
This is what we adopted in the rest of the application.

The `.data()` method must only be used when dealing with large data structure. When having only strings like here, it is OK to store them in the DOM
This commit is contained in:
Pierre Goiffon
2021-03-04 16:54:16 +01:00
parent 622b486d1f
commit 8efc688ff8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
application/cmdbabstract.class.inc.php
View File

@@ -2446,11 +2446,13 @@ JS
// N°3750 refresh container data-input-type attribute if in an Ajax context
// indeed in such a case we're only returning the field value content and not the parent container, so we need to update it !
if (utils::IsXmlHttpRequest()) {
// We are refreshing the data attribute only with the .attr() method
// So any consumer that want to get this attribute value MUST use `.attr()` and not `.data()`
// Actually the later uses a dedicated memory (that is initialized by the DOM values on page loading)
// Whereas `.attr()` uses the DOM directly
$sHTMLValue .= <<<HTML
<script>
//TODO 3.0.0 should we keep both ?
$("[data-input-id='$iId']").attr("data-input-type", "$sInputType");
$("[data-input-id='$iId']").data("input-type", "$sInputType");
</script>
HTML;
}