composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 18:48:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°4109 - Fix JS message "Gateway timeout" / "Unauthorized" / "" being displayed on object details page

Browse Source 
(cherry picked from commit e279799bf8)
This commit is contained in:
Molkobain
2021-07-04 16:46:49 +02:00
parent ebbf6e56be
commit 8e1e71c740
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/layouts/activity-panel/activity-panel.js
View File

@@ -959,8 +959,10 @@ $(function()
'json'
)
.fail(function (oXHR, sStatus, sErrorThrown) {
// TODO 3.0.0: Maybe we could have a centralized dialog to display error messages?
alert(sErrorThrown);
// In case of HTTP request failure (not lock request), put the details in the JS console
CombodoJSConsole.Error('Activity panel - Error on lock status check: '+sErrorThrown);
CombodoJSConsole.Debug('Response status: '+sStatus);
CombodoJSConsole.Debug('Response object: ', oXHR);
})
.done(function (oData) {
let sNewLockStatus = me.enums.lock_status.unknown;
@@ -993,7 +995,7 @@ $(function()
sNewLockStatus = me.enums.lock_status.locked_by_someone_else;
} else if ('expired' === oData.operation) {
sNewLockStatus = me.enums.lock_status.unknown;
// TODO 3.0.0: Maybe we could use the centralized dialog to display error message we talked about in the .fail() callback?
// TODO 3.0.0: Maybe we could use a centralized dialog to display error message?
alert(oData.popup_message);
}
} else {