composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 10:38:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°2329 PHP 7.4 compat, AttributeDefinition : fix visibilities of members called by AttributeDefinition::__construct

Browse Source 
Not enough to get rid of child classes constructors though :/
This commit is contained in:
Pierre Goiffon
2019-12-24 15:28:36 +01:00
parent 17978b829b
commit 8ab157eae4
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/attributedef.class.inc.php
View File

@@ -155,8 +155,11 @@ abstract class AttributeDefinition
return static::SEARCH_WIDGET_TYPE != static::SEARCH_WIDGET_TYPE_RAW;
}
/** @var string */
protected $m_sCode;
private $m_aParams = array();
/** @var array */
protected $m_aParams;
/** @var string */
protected $m_sHostClass = '!undefined!';
public function Get($sParamName)
@@ -264,11 +267,11 @@ abstract class AttributeDefinition
/**
* @throws \Exception
*/
private function ConsistencyCheck()
protected function ConsistencyCheck()
{
// Check that any mandatory param has been specified
//
$aExpectedParams = $this->ListExpectedParams();
$aExpectedParams = static::ListExpectedParams();
foreach($aExpectedParams as $sParamName)
{
if (!array_key_exists($sParamName, $this->m_aParams))