N°8440 Allow icon file ids to contain quotes, by correctly escaping language literals (XPath or PHP)

This commit is contained in:
Romain Quetiez
2025-06-13 09:58:59 +02:00
parent 2086052d60
commit 8a4ad87b06

View File

@@ -22,6 +22,7 @@ use Combodo\iTop\Application\Branding;
use Combodo\iTop\Application\WebPage\iTopWebPage;
use Combodo\iTop\Application\WebPage\Page;
use Combodo\iTop\DesignElement;
use Combodo\iTop\DesignDocument;
require_once(APPROOT.'setup/setuputils.class.inc.php');
require_once(APPROOT.'setup/modelfactory.class.inc.php');
@@ -3300,7 +3301,7 @@ EOF;
$sFileId = $oFileRef->getAttribute('ref');
if ($sFileId !== '')
{
$sQuotedFileId = self::QuoteForPHP($sFileId);
$sQuotedFileId = DesignDocument::XPathQuote($sFileId);
$oNodes = $this->oFactory->GetNodes("/itop_design/files/file[@id=$sQuotedFileId]");
if ($oNodes->length == 0)
{