composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-09-16 19:58:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°9906 Fix missing $ and phpunit tests

Browse Source
This commit is contained in:
Timmy38
2026-09-10 16:16:35 +02:00
parent f2731a8869
commit 8619b34e2f
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php
View File

@@ -419,7 +419,7 @@ class DataFeatureRemovalController extends Controller
$oRuntimeEnvironment = new RunTimeEnvironment($sSourceEnv, false);
$aSelectedModules = $oRuntimeEnvironment->GetModulesToLoadFromSelectedExtensions($oConfig, $aSelectedExtensions);
$this->aBasePackageModules = aSelectedModules;
$this->aBasePackageModules = $aSelectedModules;
return $aSelectedModules;
}

27
tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php
View File

@@ -55,6 +55,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node1 - A missing extension should always be disabled and unchecked, even a mandatory extension included in package' => [
@@ -81,6 +82,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => true,
'remote' => false,
'already_included' => false,
],
],
'#node2 - A mandatory extension included in package should be checked and disabled even if the "disable uninstallation check" flag is set' => [
@@ -106,6 +108,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => true,
'remote' => false,
'already_included' => false,
],
],
'#node3 - An installed non uninstallable sub extension should force its parent to be checked and disabled' => [
@@ -140,6 +143,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node3 - An installed remote sub extension should force its parent to be checked and disabled' => [
@@ -175,6 +179,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node4 - An installed uninstallable sub extension should force its parent to be checked but not disabled' => [
@@ -209,6 +214,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node4 - An installed non uninstallable sub extension should force its parent to be checked but not disabled if the "disable uninstallation check" flag is set' => [
@@ -243,6 +249,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node4 - An installed remote sub extension should force its parent to be checked but not disabled if the "disable uninstallation check" flag is set' => [
@@ -278,6 +285,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node5 - A non installed extension with missing dependencies should be not checked and disabled' => [
@@ -305,6 +313,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node5 - A non installed extension with missing dependencies should be not checked and disabled even with force uninstall' => [
@@ -332,6 +341,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node6 - An installed extension with missing dependencies and without force uninstall should be checked and disabled' => [
@@ -359,6 +369,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node7 - An installed extension with missing dependencies and with force uninstall should be checked and enabled' => [
@@ -386,6 +397,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node8 - An installed but not selected extension with missing dependencies and with force uninstall should be unchecked and enabled' => [
@@ -413,6 +425,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node9 - A not selected, not installed extension should not be checked and be enabled' => [
@@ -436,6 +449,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node10 - A selected but not installed extension should be checked and enabled' => [
@@ -459,6 +473,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node11 - An installed but not selected extension should not be checked and be enabled' => [
@@ -482,6 +497,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node12 - An installed and selected extension should be checked and enabled' => [
@@ -506,6 +522,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node13 - An installed non uninstallable extension should be checked and disabled' => [
@@ -529,6 +546,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node13 - An installed remote extension should be checked and disabled' => [
@@ -553,6 +571,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => true,
'already_included' => false,
],
],
'#node14 - An installed but not selected non uninstallable extension should be checked and enabled if the "disable uninstallation check" flag is set' => [
@@ -576,6 +595,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node14 - An installed but not selected remote extension should be checked and enabled if the "disable uninstallation check" flag is set' => [
@@ -600,6 +620,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => true,
'already_included' => false,
],
],
'#node15 - An installed non uninstallable extension should be checked and enabled if the "disable uninstallation check" flag is set' => [
@@ -623,6 +644,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node15 - An installed remote extension should be checked and enabled if the "disable uninstallation check" flag is set' => [
@@ -647,6 +669,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => true,
'already_included' => false,
],
],
'#node16 - A non installed non uninstallable sub extension should not force its parent flags' => [
@@ -681,6 +704,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node16 - A non installed remote sub extension should not force its parent flags' => [
@@ -716,6 +740,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node13 - An installed non uninstallable extension should be checked and disabled when the "disable uninstallation check" flag is not set, even if it is not selected' => [
@@ -739,6 +764,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => false,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
'#node6 - An installed extension with missing dependencies without force uninstall should be checked and disabled, even if it is not selected' => [
@@ -766,6 +792,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'dependency_issue' => true,
'mandatory' => false,
'remote' => false,
'already_included' => false,
],
],
];