composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 02:28:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°3649 - Activity panel: Improve ActivityPanel::IsCaseLogsSubmitAutonomous() robustness

Browse Source
This commit is contained in:
Molkobain
2021-01-22 13:12:33 +01:00
parent 397cd9b946
commit 7e67661d5f
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
sources/application/UI/Base/Layout/ActivityPanel/ActivityPanel.php
View File

@@ -537,14 +537,22 @@ class ActivityPanel extends UIBlock
*/
public function IsCaseLogsSubmitAutonomous(): bool
{
$bIsAutonomous = true;
$iAutonomousSubmission = 0;
$iBridgedSubmissions = 0;
foreach ($this->GetCaseLogTabsEntryForms() as $oCaseLogEntryForm) {
$bIsAutonomous = $oCaseLogEntryForm->IsSubmitAutonomous();
break;
if ($oCaseLogEntryForm->IsSubmitAutonomous()) {
$iAutonomousSubmission++;
}
else {
$iBridgedSubmissions++;
}
}
return $bIsAutonomous;
if (($iAutonomousSubmission > 0) && ($iBridgedSubmissions > 0)) {
throw new Exception('All case logs should have the same submission mode (Autonomous: '.$iAutonomousSubmission.', Bridged: '.$iBridgedSubmissions);
}
return $iAutonomousSubmission > 0;
}
/**