composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-12 23:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

⚡️ Add faster way to rename column on the same table (#676)

Browse Source 
* Add faster way to rename column on the same table
This commit is contained in:
Thomas Casteleyn
2024-11-14 14:24:45 +01:00
committed by GitHub
parent d95e7168aa
commit 7e1b1779a9
2 changed files with 55 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
setup/moduleinstaller.class.inc.php
View File

@@ -272,6 +272,17 @@ abstract class ModuleInstallerAPI
return;
}
// Simple rename
if ($sOrigTable === $sDstTable && !$bDstTableFieldExists)
{
$sFieldSpec = CMDBSource::GetFieldSpec($sOrigTable, $sOrigColumn);
$sQueryRename = /** @lang MariaDB */ "ALTER TABLE `{$sOrigTable}` CHANGE `{$sOrigColumn}` `{$sDstColumn}` {$sFieldSpec};";
CMDBSource::Query($sQueryRename);
CMDBSource::CacheReset($sOrigTable);
return;
}
// Create the destination field if necessary
if($bDstTableFieldExists === false){
$sSpec = CMDBSource::GetFieldSpec($sOrigTable, $sOrigColumn);

44
tests/php-unit-tests/unitary-tests/setup/ModuleInstallerAPITest.php
View File

@@ -240,4 +240,48 @@ SQL
$this->assertEquals('from table 1', $sFromTable1Data, "Data was not moved as expected");
$this->assertEquals('from table 2', $sFromTable2Data, "Data was not moved as expected");
}
/**
* Test that moving columns from/to the same table works
*
* @covers \ModuleInstallerAPI::MoveColumnInDB
*
* @return void
* @throws \ArchivedObjectException
* @throws \CoreException
* @throws \MySQLException
* @throws \MySQLHasGoneAwayException
* @throws \MySQLQueryHasNoResultException
*/
public function testMoveColumnInDB_SameTable(): void
{
// Info from the original table
$sOrigClass = "Person";
$sOrigAttCode = "first_name";
[$sOrigTable, $sOrigColName] = $this->GetInfoFromTable($sOrigClass, $sOrigAttCode);
// Info for the destination column
$sDstNonExistingColName = "non_existing_column";
// Save value from original table as a reference
$oPerson = MetaModel::GetObject($sOrigClass, 1);
$sOrigValue = $oPerson->Get($sOrigAttCode);
// Try to move data
ModuleInstallerAPI::MoveColumnInDB($sOrigTable, $sOrigColName, $sOrigTable, $sDstNonExistingColName);
// Check if data was actually moved
// - Either way, the column should exist
$sDstValue = CMDBSource::QueryToScalar(
<<<SQL
SELECT `{$sDstNonExistingColName}` FROM `{$sOrigTable}` WHERE `id` = 1
LIMIT 1
SQL
);
// Put data back in the original table
ModuleInstallerAPI::MoveColumnInDB($sOrigTable, $sDstNonExistingColName, $sOrigTable, $sOrigColName);
$this->assertEquals($sOrigValue, $sDstValue, "Data was not moved as expected");
}
}