composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-16 22:08:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°2045 Portal: Fix regression introduced with N°1980: New request with 2 Request Templates does not display fields

Browse Source
This commit is contained in:
Molkobain
2019-03-06 14:44:51 +01:00
parent d6a0a279a5
commit 75a0979eee
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
datamodels/2.x/itop-portal-base/portal/src/forms/objectformmanager.class.inc.php
View File

@@ -1100,10 +1100,30 @@ class ObjectFormManager extends FormManager
}
elseif ($oAttDef->GetEditClass() === 'CustomFields')
{
if (!empty($value['template_data']) && !empty($value['user_data']))
// We don't update attribute as ormCustomField comparaison is not working as excepted.
// When several templates available, "template_id" is not sent by the portal has it is a read-only select input
// therefore, the TemplateFieldsHandler::CompareValues() doesn't work.
// This use case works in the console as it always send all fields, even hidden and read-only.
// Different templates
if( isset($value['template_id'])
&& ($value['template_id'] != $value['current_template_id']) )
{
$this->oObject->Set($sAttCode, $value);
}
// Same template, different fields
elseif(isset($value['template_id'], $value['template_data'])
&& ($value['template_id'] == $value['current_template_id'])
&& ($value['template_data'] != $value['current_template_data']) )
{
$this->oObject->Set($sAttCode, $value);
}
// Update of current values
elseif(isset($value['user_data']))
{
$this->oObject->Set($sAttCode, $value);
}
// Else don't update! Otherwise we might loose current value
}
else
{