composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-22 10:08:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°3649 - Activity panel: Improve UX on "indeterminated" filters' checkboxes

Browse Source
This commit is contained in:
Molkobain
2021-02-01 16:24:32 +01:00
parent 977d1d0246
commit 648a3cc430
1 changed files with 33 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
js/layouts/activity-panel/activity-panel.js
View File

@@ -79,6 +79,7 @@ $(function()
this.element.addClass('ibo-activity-panel');
this._bindEvents();
this._UpdateMessagesCounters();
this._UpdateFiltersCheckboxesFromOptions();
this._ReformatDateTimes();
// TODO 3.0.0: Modify PopoverMenu so we can pass it the ID of the block triggering the open/close
@@ -227,15 +228,7 @@ $(function()
const oFilterOptionsElem = oInputElem.closest(this.js_selectors.activity_filter_options);
const oFilterInputElem = oInputElem.closest(this.js_selectors.tab_toolbar_action).find(this.js_selectors.activity_filter);
// If all options checked, checked the parent
if (oFilterOptionsElem.find(this.js_selectors.activity_filter_option_input + ':not(:checked)').length === 0) {
oFilterInputElem.prop('checked', true);
}
// Else, uncheck the parent
else {
oFilterInputElem.prop('checked', false);
}
this._UpdateFiltersCheckboxesFromOptions();
this._ApplyEntriesFilters();
},
_onCaseLogOpenAllClick: function(oIconElem)
@@ -449,6 +442,37 @@ $(function()
}
return iIdx;
},
/**
* Update the main filters checkboxes depending on the state of their filter's options.
* The main goal is to have an "indeterminated" state.
*
* @return {void}
* @private
*/
_UpdateFiltersCheckboxesFromOptions: function()
{
const me = this;
this.element.find(this.js_selectors.activity_filter_options).each(function(){
const oFilterOptionsElem = $(this);
const iTotalOptionsCount = oFilterOptionsElem.find(me.js_selectors.activity_filter_option_input).length;
const iCheckedOptionsCount = oFilterOptionsElem.find(me.js_selectors.activity_filter_option_input + ':checked').length;
let bChecked = false;
let bIndeterminate = false;
if (iCheckedOptionsCount === iTotalOptionsCount) {
bChecked = true;
}
else if ((0 < iCheckedOptionsCount) && (iCheckedOptionsCount < iTotalOptionsCount)) {
bIndeterminate = true;
}
oFilterOptionsElem.closest(me.js_selectors.tab_toolbar_action).find(me.js_selectors.activity_filter).prop({
indeterminate: bIndeterminate,
checked: bChecked
});
});
},
/**
* Show the oFilterElem's options
*