composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-08-22 22:28:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules (#978)

Browse Source 
* N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules

* Update unit tests

* N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules
This commit is contained in:
Lenaick
2026-07-23 16:23:06 +02:00
committed by GitHub
parent 968c56745a
commit 620a6b9a51
2 changed files with 115 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
setup/wizardsteps/WizStepModulesChoice.php
View File

@@ -758,12 +758,11 @@ EOF
if ($bMissingFromDisk) {
$bDisabled = true;
$bChecked = false;
} elseif ($bDependencyIssue) {
$bDisabled = true;
$bChecked = false;
} elseif ($bMandatory) {
$bDisabled = true;
$bChecked = true;
} elseif ($bDependencyIssue) {
$bDisabled = !$bDisableUninstallCheck;
} elseif ($bInstalled && !$bCanBeUninstalled && !$bDisableUninstallCheck) {
$bChecked = true;
$bDisabled = true;
@@ -813,6 +812,9 @@ EOF
if ($aFlags['disabled'] && !$aFlags['checked'] && !$bDisableUninstallCheck && (!$aFlags['uninstallable'] || $aFlags['mandatory'])) {
$this->bCanMoveForward = false;//Disable "Next"
} elseif (!$bDisableUninstallCheck && $aFlags['dependency_issue']) {
//If there is a dependency issue, the user cannot move forward without forced uninstall
$this->bCanMoveForward = false;
}
$this->DisplayChoice($oPage, $aChoice, $aSelectedComponents, $aDefaults, $sChoiceId, $sChoiceId, $aFlags);

112
tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php
View File

@@ -394,7 +394,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'mandatory' => false,
],
],
'A non installed extension with missing dependencies should be not checked and disabled' => [
'A non installed and non mandatory extension with missing dependencies and without force uninstall should be not checked and disabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => false,
@@ -421,7 +421,7 @@ class WizStepModulesChoiceTest extends ItopTestCase
'mandatory' => false,
],
],
'An installed extension with missing dependencies should be not checked and disabled' => [
'An installed non mandatory extension with missing dependencies and without force uninstall should be not checked and disabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => true,
@@ -448,6 +448,114 @@ class WizStepModulesChoiceTest extends ItopTestCase
'mandatory' => false,
],
],
'A non installed and non mandatory extension with missing dependencies and force uninstall should be not checked and enabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => false,
'missing_dependencies' => [
'itop-ext1-1',
],
],
],
'aWizardStepDefinition' => [
'extension_code' => 'itop-ext1',
'mandatory' => false,
'uninstallable' => true,
'missing_dependencies' => true,
],
'bCurrentSelected' => false,
'bDisableUninstallChecks' => true,
'aExpectedFlags' => [
'uninstallable' => true,
'missing' => false,
'installed' => false,
'disabled' => false,
'checked' => false,
'dependency_issue' => true,
'mandatory' => false,
],
],
'An installed non mandatory extension with missing dependencies and force uninstall should be not checked and enabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => true,
'missing_dependencies' => [
'itop-ext1-1',
],
],
],
'aWizardStepDefinition' => [
'extension_code' => 'itop-ext1',
'mandatory' => false,
'uninstallable' => true,
'missing_dependencies' => true,
],
'bCurrentSelected' => false,
'bDisableUninstallChecks' => true,
'aExpectedFlags' => [
'uninstallable' => true,
'missing' => false,
'installed' => true,
'disabled' => false,
'checked' => false,
'dependency_issue' => true,
'mandatory' => false,
],
],
'An installed mandatory extension with missing dependencies and without force uninstall should be checked and disabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => true,
'missing_dependencies' => [
'itop-ext1-1',
],
],
],
'aWizardStepDefinition' => [
'extension_code' => 'itop-ext1',
'mandatory' => true,
'uninstallable' => true,
'missing_dependencies' => true,
],
'bCurrentSelected' => false,
'bDisableUninstallChecks' => true,
'aExpectedFlags' => [
'uninstallable' => true,
'missing' => false,
'installed' => true,
'disabled' => true,
'checked' => true,
'dependency_issue' => true,
'mandatory' => true,
],
],
'An non installed mandatory extension with missing dependencies and without force uninstall should be checked and disabled' => [
'aExtensionsOnDiskOrDb' => [
'itop-ext1' => [
'installed' => false,
'missing_dependencies' => [
'itop-ext1-1',
],
],
],
'aWizardStepDefinition' => [
'extension_code' => 'itop-ext1',
'mandatory' => true,
'uninstallable' => true,
'missing_dependencies' => true,
],
'bCurrentSelected' => false,
'bDisableUninstallChecks' => true,
'aExpectedFlags' => [
'uninstallable' => true,
'missing' => false,
'installed' => false,
'disabled' => true,
'checked' => true,
'dependency_issue' => true,
'mandatory' => true,
],
],
];
}