composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

✅ N°5893 Add test for \TriggerOnObject::LogException

Browse Source
This commit is contained in:
Pierre Goiffon
2023-03-10 16:04:55 +01:00
parent d908827787
commit 5ee6223434
1 changed files with 47 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
tests/php-unit-tests/unitary-tests/core/TriggerTest.php
View File

@@ -4,7 +4,10 @@ namespace Combodo\iTop\Test\UnitTest\Core;
use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
use ContextTag;
use Exception;
use IssueLog;
use MetaModel;
use Person;
use TriggerOnObjectCreate;
/**
@@ -14,7 +17,6 @@ use TriggerOnObjectCreate;
*
* @runTestsInSeparateProcesses
*/
class TriggerTest extends ItopDataTestCase
{
const USE_TRANSACTION = false;
@@ -40,33 +42,29 @@ class TriggerTest extends ItopDataTestCase
public function testEnrichRaisedException_Trigger()
{
$oTrigger = MetaModel::NewObject('TriggerOnObjectCreate');
try
{
try
{
try {
try {
MetaModel::NewObject('Toto');
}
catch (\Exception $e)
{
catch (\Exception $e) {
\utils::EnrichRaisedException($oTrigger, $e);
}
$this->assertTrue(false, "An exception should have been thrown");
}
catch(\CoreException $e1)
{
catch (\CoreException $e1) {
$this->assertEquals('CoreException', get_class($e1));
$this->assertEquals('Unknown class \'Toto\' (<b title="Trigger">TriggerOnObjectCreate</b>::-1 ()<br/>)', $e1->getMessage());
$fullStackTraceAsString = $e1->getFullStackTraceAsString();
$this->assertContains("MetaModel::NewObject", $fullStackTraceAsString,"new enriched exception should contain root cause method: " . $fullStackTraceAsString);
$this->assertContains("MetaModel::NewObject", $fullStackTraceAsString, "new enriched exception should contain root cause method: ".$fullStackTraceAsString);
}
}
public function NoEnrichmentProvider()
{
return [
[ null ],
[ new NonCmdbAbstractObject() ],
[null],
[new NonCmdbAbstractObject()],
] ;
}
@@ -76,23 +74,52 @@ class TriggerTest extends ItopDataTestCase
*/
public function testEnrichRaisedException_NoEnrichment($oCmdbAbstract)
{
try
{
try
{
try {
try {
MetaModel::NewObject('CoreException');
}
catch (\Exception $e)
{
catch (\Exception $e) {
\utils::EnrichRaisedException($oCmdbAbstract, $e);
}
$this->assertTrue(false, "An exception should have been thrown");
}
catch(\Exception $e1)
{
catch (\Exception $e1) {
$this->assertEquals($e, $e1);
}
}
public function testLogException()
{
$sTestLogPath = APPROOT.'log/TriggerTest__testLogException.log';
IssueLog::Enable($sTestLogPath);
try {
$oPerson1 = MetaModel::GetObject(Person::class, 1, true);
$sExceptionMessage = 'My test exception message';
$oException = new Exception($sExceptionMessage);
/** @var TriggerOnObjectCreate $oTrigger */
$oTrigger = MetaModel::NewObject(TriggerOnObjectCreate::class, [
'description' => 'my trigger description',
]);
$oTrigger->DBWrite();
$oTrigger->LogException($oException, $oPerson1);
$sTestLogFileContent = file_get_contents($sTestLogPath);
$this->assertContains('A trigger did throw an exception', $sTestLogFileContent);
$this->assertContains($oPerson1->GetKey(), $sTestLogFileContent);
/** @noinspection GetClassUsageInspection */
$this->assertContains(get_class($oPerson1), $sTestLogFileContent);
$this->assertContains($oPerson1->GetRawName(), $sTestLogFileContent);
$this->assertContains($sExceptionMessage, $sTestLogFileContent);
}
finally {
IssueLog::Enable(APPROOT.'log/error.log');
}
}
}
class NonCmdbAbstractObject{