composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-20 17:18:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°2847 - Global search: Add config. parameter for max. history results ('global_search.max_history_results')

Browse Source
This commit is contained in:
Molkobain
2020-10-09 09:46:42 +02:00
parent 2ae50dfb06
commit 5bc01d3950
3 changed files with 39 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/config.class.inc.php
View File

@@ -1160,6 +1160,14 @@ class Config
'source_of_value' => '',
'show_in_conf_sample' => false,
),
'global_search.max_history_results' => array(
'type' => 'integer',
'description' => 'Max. number of elements in the history.',
'default' => 10,
'value' => 10,
'source_of_value' => '',
'show_in_conf_sample' => false,
),
'breadcrumb.enabled' => array(
'type' => 'bool',
'description' => 'Whether or not the breadcrumbs is enabled',

13
sources/application/UI/Component/GlobalSearch/GlobalSearch.php
View File

@@ -21,6 +21,7 @@ namespace Combodo\iTop\Application\UI\Component\GlobalSearch;
use Combodo\iTop\Application\UI\UIBlock;
use MetaModel;
use utils;
/**
@@ -47,6 +48,8 @@ class GlobalSearch extends UIBlock
protected $sEndpoint;
/** @var array $aLastQueries */
protected $aLastQueries;
/** @var int $iMaxHistoryResults Max. number of elements in the history */
protected $iMaxHistoryResults;
/**
* GlobalSearch constructor.
@@ -61,6 +64,7 @@ class GlobalSearch extends UIBlock
parent::__construct($sId);
$this->SetEndpoint(static::DEFAULT_ENDPOINT_REL_URL);
$this->SetLastQueries($aLastQueries);
$this->iMaxHistoryResults = (int) MetaModel::GetConfig()->Get('quick_create.max_history_results');
}
/**
@@ -114,4 +118,13 @@ class GlobalSearch extends UIBlock
{
return $this->aLastQueries;
}
/**
* @see $iMaxHistoryResults
* @return int
*/
public function GetMaxHistoryResults(): int
{
return $this->iMaxHistoryResults;
}
}

23
sources/application/UI/Component/GlobalSearch/GlobalSearchHelper.php
View File

@@ -21,6 +21,7 @@ namespace Combodo\iTop\Application\UI\Component\GlobalSearch;
use appUserPreferences;
use MetaModel;
use utils;
/**
@@ -33,7 +34,7 @@ use utils;
*/
class GlobalSearchHelper
{
public const MAX_HISTORY_SIZE = 10;
/** @var string */
public const USER_PREF_CODE = 'global_search_history';
/**
@@ -86,10 +87,7 @@ class GlobalSearchHelper
array_unshift($aHistoryEntries, $aNewEntry);
// Truncate history
if(count($aHistoryEntries) > static::MAX_HISTORY_SIZE)
{
$aHistoryEntries = array_slice($aHistoryEntries, 0, static::MAX_HISTORY_SIZE);
}
static::TruncateHistory($aHistoryEntries);
appUserPreferences::SetPref(static::USER_PREF_CODE, $aHistoryEntries);
}
@@ -107,6 +105,7 @@ class GlobalSearchHelper
{
/** @var array $aHistoryEntries */
$aHistoryEntries = appUserPreferences::GetPref(static::USER_PREF_CODE, []);
static::TruncateHistory($aHistoryEntries);
for($iIdx = 0; $iIdx < count($aHistoryEntries); $iIdx++)
{
@@ -125,4 +124,18 @@ class GlobalSearchHelper
return $aHistoryEntries;
}
/**
* Truncate $aHistoryEntries to 'global_search.max_history_results' entries
*
* @param array $aHistoryEntries
*/
protected static function TruncateHistory(array &$aHistoryEntries): void
{
$iMaxHistoryResults = (int) MetaModel::GetConfig()->Get('global_search.max_history_results');
if(count($aHistoryEntries) > $iMaxHistoryResults)
{
$aHistoryEntries = array_slice($aHistoryEntries, 0, $iMaxHistoryResults);
}
}
}