composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°1915 import : fix cannot create object with value for field that is readonly in modification

Browse Source 
GetAttributeFlags method returns OPT_ATT_READONLY for this field, but not GetInitialStateAttributeFlags method
This commit is contained in:
Pierre Goiffon
2018-12-28 18:16:32 +01:00
parent 778db225a8
commit 523e19528e
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
core/bulkchange.class.inc.php
View File

@@ -332,7 +332,20 @@ class BulkChange
return true;
}
protected function PrepareObject(&$oTargetObj, $aRowData, &$aErrors)
/**
* @param \DBObject $oTargetObj
* @param array $aRowData
* @param array $aErrors
* @param bool $bIsNewObject
*
* @return array
* @throws \CoreException
* @throws \CoreUnexpectedValue
* @throws \MissingQueryArgument
* @throws \MySQLException
* @throws \MySQLHasGoneAwayException
*/
protected function PrepareObject(&$oTargetObj, $aRowData, &$aErrors, $bIsNewObject = false)
{
$aResults = array();
$aErrors = array();
@@ -477,7 +490,9 @@ class BulkChange
if (!$oAttDef->IsWritable() && in_array($sAttCode, $this->m_aReconcilKeys)){ continue; }
$aReasons = array();
$iFlags = $oTargetObj->GetAttributeFlags($sAttCode, $aReasons);
$iFlags = ($bIsNewObject)
? $oTargetObj->GetInitialStateAttributeFlags($sAttCode, $aReasons)
: $oTargetObj->GetAttributeFlags($sAttCode, $aReasons);
if ( (($iFlags & OPT_ATT_READONLY) == OPT_ATT_READONLY) && ( $oTargetObj->Get($sAttCode) != $aRowData[$iCol]) )
{
$aErrors[$sAttCode] = Dict::Format('UI:CSVReport-Value-Issue-Readonly', $sAttCode, $oTargetObj->Get($sAttCode), $aRowData[$iCol]);
@@ -685,7 +700,7 @@ class BulkChange
}
}
$aResult[$iRow] = $this->PrepareObject($oTargetObj, $aRowData, $aErrors);
$aResult[$iRow] = $this->PrepareObject($oTargetObj, $aRowData, $aErrors, true);
if (count($aErrors) > 0)
{
@@ -733,7 +748,7 @@ class BulkChange
protected function UpdateObject(&$aResult, $iRow, $oTargetObj, $aRowData, CMDBChange $oChange = null)
{
$aResult[$iRow] = $this->PrepareObject($oTargetObj, $aRowData, $aErrors);
$aResult[$iRow] = $this->PrepareObject($oTargetObj, $aRowData, $aErrors, false);
// Reporting
//