composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-19 00:28:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

5874

Browse Source 
Add comments to tests for clarity
This commit is contained in:
xavier.guiboud-ribaud@combodo.com
2024-11-22 16:34:09 +01:00
parent 585072a478
commit 44fa08278d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/php-unit-tests/unitary-tests/sources/Application/UI/Base/Components/QuickCreate/QuickCreateHelperTest.php
View File

@@ -13,11 +13,11 @@ class QuickCreateHelperTest extends ItopDataTestCase
*/
public function testNoDuplicateInPopularAndLast()
{
$sPopularClass = 'UserRequest';
$aClasses = ['ApplicationSolution', 'BusinessProcess', 'DatabaseSchema', 'MiddlewareInstance', 'Enclosure'];
$aPopularClassesInitial = QuickCreateHelper::GetPopularClasses(); // Should contain UserRequest
$aPopularClassesInitial = QuickCreateHelper::GetPopularClasses(); // Should contain the first Popular class (FunctionalCI if default)
$sPopularClass = $aPopularClassesInitial[0]['class'];
QuickCreateHelper::AddClassToHistory($sPopularClass);
$aPopularClassNoParam = QuickCreateHelper::GetPopularClasses(); // UserRequest should now be in Recents and no longer in Popular
$aPopularClassNoParam = QuickCreateHelper::GetPopularClasses(); // Popular class should now be in Recents and no longer in Popular
for($iIdx = 0; $iIdx < count($aPopularClassNoParam); $iIdx++)
{
@@ -36,7 +36,7 @@ class QuickCreateHelperTest extends ItopDataTestCase
foreach($aClasses as $sClass)
{
QuickCreateHelper::AddClassToHistory($sClass); // Creating as many classes as needed for UserRequest to no longer be in the Recent classes
QuickCreateHelper::AddClassToHistory($sClass); // Creating as many classes as needed for UserRequest to no longer be in the Recent classes (at least equal to 'quick_create.max_history_results')
}
$aPopularClassesFinal = QuickCreateHelper::GetPopularClasses(); // Should contain UserRequest
$this->assertEquals($aPopularClassesInitial, $aPopularClassesFinal);