Rename method to better match its usage

This commit is contained in:
Molkobain
2021-06-28 10:35:43 +02:00
parent 9f75fae33f
commit 410948fb4e
3 changed files with 5 additions and 5 deletions

View File

@@ -2303,7 +2303,7 @@ class MenuBlock extends DisplayBlock
// Toolkit actions
if (!empty($aToolkitActions)) {
foreach ($aToolkitActions as $sActionId => $aActionData) {
$oRegularActionsMenu->AddItem('toolkit-actions', PopoverMenuItemFactory::MakeFromDisplayBlockAction($sActionId, $aActionData));
$oRegularActionsMenu->AddItem('toolkit-actions', PopoverMenuItemFactory::MakeFromApplicationPopupMenuItemData($sActionId, $aActionData));
}
}
}

View File

@@ -190,7 +190,7 @@ class PopoverMenuFactory
$aTransformedItems = [];
foreach($aOriginalItems as $sItemID => $aItemData) {
$aTransformedItems[] = PopoverMenuItemFactory::MakeFromDisplayBlockAction($sItemID, $aItemData);
$aTransformedItems[] = PopoverMenuItemFactory::MakeFromApplicationPopupMenuItemData($sItemID, $aItemData);
}
return $aTransformedItems;
@@ -265,7 +265,7 @@ class PopoverMenuFactory
}
foreach ($aActions as $sActionId => $aAction) {
$oMenu->AddItem($sSection, PopoverMenuItemFactory::MakeFromDisplayBlockAction($sActionId, $aAction));
$oMenu->AddItem($sSection, PopoverMenuItemFactory::MakeFromApplicationPopupMenuItemData($sActionId, $aAction));
}
$bFirst = false;

View File

@@ -67,7 +67,7 @@ class PopoverMenuItemFactory
}
/**
* Make a PopoverMenuItem from an action prepared by \DisplayBlock
* Make a PopoverMenuItem from an action data as return by {@see ApplicationPopupMenuItem::GetMenuItem()}
*
* @param string $sActionId
* @param array $aActionData
@@ -75,7 +75,7 @@ class PopoverMenuItemFactory
* @return \Combodo\iTop\Application\UI\Base\Component\PopoverMenu\PopoverMenuItem\PopoverMenuItem
* @throws \Exception
*/
public static function MakeFromDisplayBlockAction(string $sActionId, array $aActionData)
public static function MakeFromApplicationPopupMenuItemData(string $sActionId, array $aActionData)
{
$aRefactoredItem = [
'uid' => $sActionId,