composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 15:34:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°6442 - Error in Database integrity due to "translate placeholder in notification"

Browse Source
This commit is contained in:
Eric Espie
2023-06-27 15:23:28 +02:00
parent 98d4fa4331
commit 2c8db92504
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
datamodels/2.x/combodo-db-tools/db_analyzer.class.inc.php
View File

@@ -462,6 +462,11 @@ class DatabaseAnalyzer
$aCols = $oAttDef->GetSQLExpressions(); // Workaround a PHP bug: sometimes issuing a Notice if invoking current(somefunc())
$sMyAttributeField = current($aCols); // get the first column for the moment
$sFilter = "FROM `$sTable` WHERE `$sTable`.`$sMyAttributeField` NOT IN ($sExpectedValues)";
if ($oAttDef->IsNullAllowed()) {
$sSearchType = $oAttDef->GetSearchType();
$sCondition = $this->NotEmptyToSql("`$sTable`.`$sMyAttributeField`", $sSearchType);
$sFilter .= " AND $sCondition";
}
$sDelete = "DELETE `$sTable`";
$sSelect = "SELECT DISTINCT `$sTable`.`$sKeyField` AS id, `$sTable`.`$sMyAttributeField` AS value";
$sSelWrongRecs = "$sSelect $sFilter";
@@ -492,6 +497,19 @@ class DatabaseAnalyzer
}
}
private function NotEmptyToSql($sRef, $sSearchType)
{
switch ($sSearchType) {
case AttributeDefinition::SEARCH_WIDGET_TYPE_NUMERIC:
case AttributeDefinition::SEARCH_WIDGET_TYPE_EXTERNAL_FIELD:
case AttributeDefinition::SEARCH_WIDGET_TYPE_DATE:
case AttributeDefinition::SEARCH_WIDGET_TYPE_DATE_TIME:
return "ISNULL({$sRef}) = 0";
}
return "({$sRef} != '')";
}
/**
* Check user accounts without profile
*