composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-12 23:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Code refactoring: coloring a relation graph (purpose: distinguish potentially impacted CIs and really impacted CIs, when analyzing a change ticket)

Browse Source 
SVN:trunk[3568]
This commit is contained in:
Romain Quetiez
2015-04-28 15:50:14 +00:00
parent 95defedf08
commit 255df92a30
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
core/relationgraph.class.inc.php
View File

@@ -77,15 +77,15 @@ class RelationObjectNode extends GraphNode
/**
* Recursively mark the objects nodes as reached, unless we get stopped by a redundancy node
*/
public function ReachDown()
public function ReachDown($sProperty, $value)
{
if (!$this->GetProperty('is_reached', false))
if (is_null($this->GetProperty($sProperty)))
{
$this->SetProperty('is_reached', true);
$this->SetProperty($sProperty, $value);
foreach ($this->GetOutgoingEdges() as $oOutgoingEdge)
{
// Recurse
$oOutgoingEdge->GetSinkNode()->ReachDown();
$oOutgoingEdge->GetSinkNode()->ReachDown($sProperty, $value);
}
}
}
@@ -101,7 +101,6 @@ class RelationRedundancyNode extends GraphNode
parent::__construct($oGraph, $sId);
$this->SetProperty('min_up', $iMinUp);
$this->SetProperty('threshold', $fThreshold);
$this->SetProperty('reach_count', 0);
}
/**
@@ -125,16 +124,16 @@ class RelationRedundancyNode extends GraphNode
/**
* Recursively mark the objects nodes as reached, unless we get stopped by a redundancy node
*/
public function ReachDown()
public function ReachDown($sProperty, $value)
{
$this->SetProperty('reach_count', $this->GetProperty('reach_count', 0) + 1);
if ($this->GetProperty('reach_count') > $this->GetProperty('threshold'))
$this->SetProperty($sProperty.'_count', $this->GetProperty($sProperty.'_count', 0) + 1);
if ($this->GetProperty($sProperty.'_count') > $this->GetProperty('threshold'))
{
// Looping... though there should be only ONE SINGLE outgoing edge
foreach ($this->GetOutgoingEdges() as $oOutgoingEdge)
{
// Recurse
$oOutgoingEdge->GetSinkNode()->ReachDown();
$oOutgoingEdge->GetSinkNode()->ReachDown($sProperty, $value);
}
}
}
@@ -214,7 +213,7 @@ class RelationGraph extends SimpleGraph
// Determine the reached nodes
foreach ($this->aSourceNodes as $oSourceNode)
{
$oSourceNode->ReachDown();
$oSourceNode->ReachDown('is_reached', true);
//echo "<h5>After reaching from {$oSourceNode->GetId()}</h5>\n".$this->DumpAsHtmlImage()."<br/>\n";
}
}