composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-22 18:18:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

DictionariesConsistencyTest : fix inspections warnings

Browse Source
This commit is contained in:
Pierre Goiffon
2021-04-07 09:15:20 +02:00
parent 3941f323c0
commit 1b6d69037e
1 changed files with 13 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/integration/DictionariesConsistencyTest.php
View File

@@ -27,7 +27,7 @@ class DictionariesConsistencyTest extends ItopTestCase
*
* @param $sDictFile
*/
public function testDictionariesLanguage($sDictFile)
public function testDictionariesLanguage($sDictFile): void
{
$aPrefixToLanguageData = array(
'cs' => array('CS CZ', 'Czech', 'Čeština'),
@@ -48,51 +48,43 @@ class DictionariesConsistencyTest extends ItopTestCase
'zh_cn' => array('ZH CN', 'Chinese', '简体中文'),
);
if (!preg_match('/^(.*)\\.dict/', basename($sDictFile), $aMatches))
{
if (!preg_match('/^(.*)\\.dict/', basename($sDictFile), $aMatches)) {
static::fail("Dictionary file '$sDictFile' not matching the naming convention");
}
$sLangPrefix = $aMatches[1];
if (!array_key_exists($sLangPrefix, $aPrefixToLanguageData))
{
if (!array_key_exists($sLangPrefix, $aPrefixToLanguageData)) {
static::fail("Unknown prefix '$sLangPrefix' for dictionary file '$sDictFile'");
}
$sExpectedLanguageCode = $aPrefixToLanguageData[$sLangPrefix][0];
$sExpectedEnglishLanguageDesc = $aPrefixToLanguageData[$sLangPrefix][1];
$sExpectedLocalizedLanguageDesc = $aPrefixToLanguageData[$sLangPrefix][2];
[$sExpectedLanguageCode, $sExpectedEnglishLanguageDesc, $sExpectedLocalizedLanguageDesc] = $aPrefixToLanguageData[$sLangPrefix];
$sDictPHP = file_get_contents($sDictFile);
if ($iCount = preg_match_all("@Dict::Add\('(.*)'\s*,\s*'(.*)'\s*,\s*'(.*)'@", $sDictPHP, $aMatches) === false)
{
$iCount = preg_match_all("@Dict::Add\('(.*)'\s*,\s*'(.*)'\s*,\s*'(.*)'@", $sDictPHP, $aMatches);
if ($iCount === false) {
static::fail("Pattern not working");
}
if ($iCount == 0)
{
if ($iCount === 0) {
// Empty dictionary, that's fine!
static::assertTrue(true);
}
foreach ($aMatches[1] as $sLanguageCode)
{
foreach ($aMatches[1] as $sLanguageCode) {
static::assertSame($sExpectedLanguageCode, $sLanguageCode,
"Unexpected language code for Dict::Add in dictionary $sDictFile");
}
foreach ($aMatches[2] as $sEnglishLanguageDesc)
{
foreach ($aMatches[2] as $sEnglishLanguageDesc) {
static::assertSame($sExpectedEnglishLanguageDesc, $sEnglishLanguageDesc,
"Unexpected language description (english) for Dict::Add in dictionary $sDictFile");
}
foreach ($aMatches[3] as $sLocalizedLanguageDesc)
{
foreach ($aMatches[3] as $sLocalizedLanguageDesc) {
static::assertSame($sExpectedLocalizedLanguageDesc, $sLocalizedLanguageDesc,
"Unexpected language description for Dict::Add in dictionary $sDictFile");
}
}
public function DictionaryFileProvider()
public function DictionaryFileProvider(): array
{
static::setUp();
$this->setUp();
$aDictFiles = array_merge(
glob(APPROOT.'datamodels/2.x/*/*.dict*.php'), // legacy form in modules
@@ -148,6 +140,6 @@ class DictionariesConsistencyTest extends ItopTestCase
$bDictFileSyntaxOk = ($return === 0);
$sMessage = "File `{$sDictFile}` syntax didn't matched expectations\nparsing results=".var_export($output, true);
$this->assertEquals($bIsSyntaxValid, $bDictFileSyntaxOk, $sMessage);
self::assertEquals($bIsSyntaxValid, $bDictFileSyntaxOk, $sMessage);
}
}