composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-22 18:18:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Internal: Refactor some harcoded attribute codes into constants in UserRights

Browse Source
This commit is contained in:
Molkobain
2020-07-28 09:18:59 +02:00
parent 3b6654588a
commit 1766d42350
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/userrights.class.inc.php
View File

@@ -644,6 +644,12 @@ interface iSelfRegister
*/
class UserRights
{
const DEFAULT_USER_CONTACT_ID_ATTCODE = 'contactid';
const DEFAULT_CONTACT_ORG_ID_ATTCODE = 'org_id';
const DEFAULT_CONTACT_ORG_ID_FRIENDLYNAME_ATTCODE = self::DEFAULT_CONTACT_ORG_ID_ATTCODE.'_friendlyname';
const DEFAULT_CONTACT_FIRSTNAME_ATTCODE = 'first_name';
const DEFAULT_CONTACT_PICTURE_ATTCODE = 'picture';
public static $m_aCacheUsers;
/** @var UserRightsAddOnAPI $m_oAddOn */
protected static $m_oAddOn;
@@ -1064,11 +1070,11 @@ class UserRights
{
return '';
}
if (!MetaModel::IsValidAttCode(get_class($oUser), 'contactid'))
if (!MetaModel::IsValidAttCode(get_class($oUser), static::DEFAULT_USER_CONTACT_ID_ATTCODE))
{
return '';
}
return $oUser->Get('contactid');
return $oUser->Get(static::DEFAULT_USER_CONTACT_ID_ATTCODE);
}
/**