composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

✅ Optimize tests execution time (force cache usage and set the modification date in the past instead of waiting 1s)

Browse Source
This commit is contained in:
Romain Quetiez
2023-10-27 15:45:28 +02:00
parent 39d2ba8d1b
commit 00b1156526
2 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
sources/Service/Router/Router.php
View File

@@ -40,6 +40,11 @@ class Router
return static::$oSingleton;
}
/**
* @var bool $bUseCache
*/
protected $bUseCache = null;
/**********************/
/* Non-static methods */
/**********************/
@@ -54,6 +59,14 @@ class Router
// Don't do anything, we don't want to be initialized
}
/**
* @param bool|null $bUseCache Force cache usage for testing purposes, or leave it null for the default behavior
*/
public function SetUseCache(?bool $bUseCache): void
{
$this->bUseCache = $bUseCache;
}
/**
* Generate a complete URL for a specific route and optional parameters
*
@@ -137,7 +150,7 @@ class Router
public function GetRoutes(): array
{
$aRoutes = [];
$bUseCache = false === utils::IsDevelopmentEnvironment();
$bUseCache = is_null($this->bUseCache) ? (false === utils::IsDevelopmentEnvironment()) : $this->bUseCache;
$bMustWriteCache = false;
$sCacheFilePath = $this->GetCacheFileAbsPath();

13
tests/php-unit-tests/unitary-tests/sources/Service/Router/RouterTest.php
View File

@@ -28,6 +28,10 @@ class RouterTest extends ItopDataTestCase
parent::setUp();
$this->RequireOnceItopFile('setup/setuputils.class.inc.php');
// Speedup test by forcing the use of the cache, even on a development environment
$oRouter = Router::GetInstance();
$oRouter->SetUseCache(true);
}
/**
@@ -203,12 +207,9 @@ class RouterTest extends ItopDataTestCase
$this->fail("Cache file was not generated ($sRoutesCacheFilePath)");
}
clearstatcache();
$iFirstModificationTimestamp = filemtime($sRoutesCacheFilePath);
$this->debug("Initial timestamp: $iFirstModificationTimestamp");
// Wait for just 1s to ensure timestamps would be different is the file is re-generated
sleep(1);
// Set its modification date in the past so that regenerating it will result in a new modification date without any doubt
$iFirstModificationTimestamp = time() - 2;
touch($sRoutesCacheFilePath, $iFirstModificationTimestamp);
// Call GetRoutes() again to see if cache gets re-generated or not
$this->InvokeNonPublicMethod(Router::class, 'GetRoutes', $oRouter, []);