composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-08-22 22:28:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°9829 - Add unit tests for parent ticket changes (#979)

Browse Source
This commit is contained in:
Benjamin Dalsass
2026-07-23 15:32:53 +02:00
committed by GitHub
parent a808e89c30
commit 006dd3d6c2
1 changed files with 124 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

124
tests/php-unit-tests/unitary-tests/core/UserRightsTest.php
View File

@@ -37,6 +37,7 @@ use Dict;
use MetaModel;
use UserLocal;
use UserRights;
use UserRightsProfile;
use utils;
/**
@@ -155,6 +156,129 @@ class UserRightsTest extends ItopDataTestCase
return $oUser;
}
/**
* Ensure profiles are obtained with persisted user when profiles list has NOT been changed.
* @see N°9723 - IsActionAllowed should work with non instantiated users objects
* @covers UserRightsProfile::ListProfiles
*/
public function testListProfilesUsesPersistedProfilesWhenOnlyNonProfileChangesExist(): void
{
// Create a user with a set of profiles and save it
$oUserInDataBase = $this->GivenUserWithProfiles('test1', [
self::$aURP_Profiles['Configuration Manager'],
self::$aURP_Profiles['Support Agent'],
self::$aURP_Profiles['Service Manager'],
]);
$oUserInDataBase->DBInsert();
// User to check profiles (give the persisted user id)
$oUser = new class ($oUserInDataBase) {
private $oUserInDataBase;
public function __construct($oUserInDataBase)
{
$this->oUserInDataBase = $oUserInDataBase;
}
public function ListChanges(): array
{
return ['login' => 'changed'];
}
public function GetKey(): int
{
return $this->oUserInDataBase->GetKey();
}
public function Get(string $sAttCode)
{
if ($sAttCode === 'profile_list') {
throw new \LogicException('profile_list should not be read when it is not part of ListChanges');
}
return null;
}
};
// List the profiles (persisted)
$oUserRights = new UserRightsProfile();
$aProfiles = $oUserRights->ListProfiles($oUser);
// Asserts
$this->assertCount(3, $aProfiles);
$this->assertArrayHasKey(3, $aProfiles);
$this->assertArrayHasKey(5, $aProfiles);
$this->assertArrayHasKey(10, $aProfiles);
}
/**
* Ensure profiles are obtained with object in memory when profiles list has been changed.
* @see N°9723 - IsActionAllowed should work with non instantiated users objects
* @covers UserRightsProfile::ListProfiles
*/
public function testListProfilesUsesInMemoryProfilesWhenProfileListChanged(): void
{
// First profile
$oUserProfile1 = new class () {
public function Get(string $sAttCode)
{
if ($sAttCode === 'profileid') {
return 3;
}
if ($sAttCode === 'profileid_friendlyname') {
return 'Configuration Manager';
}
return null;
}
};
// Second profile
$oUserProfile2 = new class () {
public function Get(string $sAttCode)
{
if ($sAttCode === 'profileid') {
return 12;
}
if ($sAttCode === 'profileid_friendlyname') {
return 'Portal power user';
}
return null;
}
};
// User in memory with first and second profile
$oUser = new class ($oUserProfile1, $oUserProfile2) {
private $aProfileList;
public function __construct($oUserProfile1, $oUserProfile2)
{
$this->aProfileList = [$oUserProfile1, $oUserProfile2];
}
public function ListChanges(): array
{
return ['profile_list' => true, 'login' => 'changed'];
}
public function Get(string $sAttCode)
{
if ($sAttCode === 'profile_list') {
return $this->aProfileList;
}
return null;
}
};
// List the profiles (memory)
$oUserRights = new UserRightsProfile();
$aProfiles = $oUserRights->ListProfiles($oUser);
// Asserts
$this->assertSame([
3 => 'Configuration Manager',
12 => 'Portal power user',
], $aProfiles);
}
public function testIsLoggedIn()
{
$this->assertFalse(UserRights::IsLoggedIn());