Files
iTop/test/core/Log/ExceptionLogTest.php
bruno-ds 6e0d570d41 N°4261 - Portal exception logging: Add exception's file and line to the context.
plus:
 - the exception object is no more automatically added to the error.log context (it's way too verbose)
 - code cleanup (use constant instead of repeated strings)
 - ExceptionLog main method is now named `LogException` instead of `FromException`
2021-09-20 12:27:39 +02:00

194 lines
6.6 KiB
PHP

<?php
/*
* Copyright (C) 2013-2021 Combodo SARL
* This file is part of iTop.
* iTop is free software; you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* iTop is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
* You should have received a copy of the GNU Affero General Public License
*/
namespace Combodo\iTop\Test\UnitTest\Core\Log;
use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
use ExceptionLog;
require_once (__DIR__.'/ExceptionLogTest/Exceptions.php');
class ExceptionLogTest extends ItopDataTestCase
{
protected function setUp()
{
require_once (__DIR__.'/ExceptionLogTest/Exceptions.php');
parent::setUp();
$oConfig = \MetaModel::GetConfig();
$oConfig->Set('developer_mode.enabled', false);
}
/**
* @dataProvider logProvider
*/
public function testLogInFile($aLevels, $aExceptions, $sChannel, $aExpectedWriteNumber, $logLevelMin, $aExpectedDbWriteNumber, $logLevelMinWriteInDb)
{
$mockFileLog = $this->createMock('FileLog');
$oMockConfig = $this->createMock('Config');
$oMockConfig
->method("Get")
->willReturnCallback(function ($code) use ($logLevelMin, $logLevelMinWriteInDb) {
switch ($code) {
case 'log_level_min':
if (is_null($logLevelMin))
{
$logLevelMin = '';//this should be the default value, if it did change, please fix it here
}
return $logLevelMin;
case 'log_level_min.write_in_db':
if (is_null($logLevelMinWriteInDb))
{
$logLevelMinWriteInDb = [ 'Exception' => 'Error', ];//this should be the default value, if it did change, please fix it here
}
return $logLevelMinWriteInDb;
}
return '';
});
$aContext = ['contextKey1' => 'value'];
foreach ($aLevels as $i => $sLevel) {
$oException = new $aExceptions[$i]("Iteration number $i");
$iExpectedWriteNumber = $aExpectedWriteNumber[$i];
$iExpectedDbWriteNumber = $aExpectedDbWriteNumber[$i];
$aExpectedFileContext = array_merge($aContext, ['__exception class' => get_class($oException)]); //The context is preserved, and, if the key '__exception' is not yet in the array, it is added
$mockFileLog->expects($this->exactly($iExpectedWriteNumber))
->method($sLevel)
->with($oException->GetMessage(), $sChannel, $aExpectedFileContext)
;
ExceptionLog::MockStaticObjects($mockFileLog, $oMockConfig);
ExceptionLog::LogException($oException, $aContext, $sLevel);
$oExpectedLastEventIssue = $this->InvokeNonPublicStaticMethod('ExceptionLog', 'GetLastEventIssue', []);
if (0 == $iExpectedDbWriteNumber) {
$this->assertNull($oExpectedLastEventIssue);
} else {
$this->assertInstanceOf(\EventIssue::class, $oExpectedLastEventIssue);
$this->assertEquals($aExpectedFileContext, $oExpectedLastEventIssue->Get('data'));
}
}
}
public function logProvider()
{
return [
'use parent' => [
'aLevels' => ['Debug'],
'aExceptions' => [\GrandChildException::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [1],
'logLevelMin' => ['Exception' => 'Debug'],
'iExpectedDbWriteNumber' => [1],
'logLevelMinWriteInDb' => ['Exception' => 'Debug'],
],
'flat configuration' => [
'aLevels' => ['Debug'],
'aExceptions' => [\GrandChildException::class],
'sChannel' => 'GrandChildException',
'aExpectedWriteNumber' => [1],
'logLevelMin' => 'Debug',
'iExpectedDbWriteNumber' => [1],
'logLevelMinWriteInDb' => 'Debug',
],
'Default conf has expected levels' => [
'aLevels' => ['Debug', 'Warning'],
'aExceptions' => [\GrandChildException::class, \GrandChildException::class],
'sChannel' => 'GrandChildException',
'aExpectedWriteNumber' => [0, 1],
'logLevelMin' => null,
'iExpectedDbWriteNumber' => [0, 0],
'logLevelMinWriteInDb' => null,
],
'use correct order in inheritance tree' => [
'aLevels' => ['Trace', 'Debug', 'Info', 'Error'],
'aExceptions' => [\GrandChildException::class, \GrandChildException::class, \GrandChildException::class, \GrandChildException::class],
'sChannel' => 'GrandChildException',
'aExpectedWriteNumber' => [0, 1, 1, 1],
'logLevelMin' => ['ChildException' => 'Error', 'GrandChildException' => 'Debug', ],
'iExpectedDbWriteNumber' => [0, 1, 1, 1],
'logLevelMinWriteInDb' => ['ChildException' => 'Error', 'GrandChildException' => 'Debug', ],
],
'handle namespaced classes' => [
'aLevels' => ['Debug'],
'aExceptions' => [\Namespaced\Exception\ExceptionInNamespace::class],
'sChannel' => 'Namespaced\Exception\ExceptionInNamespace',
'aExpectedWriteNumber' => [1],
'logLevelMin' => ['Namespaced\Exception\ExceptionInNamespace' => 'Debug'],
'iExpectedDbWriteNumber' => [1],
'logLevelMinWriteInDb' => ['Namespaced\Exception\ExceptionInNamespace' => 'Debug'],
],
'not enabled by default' => [
'aLevels' => ['Debug'],
'aExceptions' => [\Exception::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [0],
'logLevelMin' => null,
'iExpectedDbWriteNumber' => [0],
'logLevelMinWriteInDb' => null,
],
'explicitly disabled' => [
'aLevels' => ['Info'],
'aExceptions' => [\Exception::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [0],
'logLevelMin' => ['Exception' => 'Error'],
'iExpectedDbWriteNumber' => [0],
'logLevelMinWriteInDb' => ['Exception' => 'Error'],
],
'default channel, default conf' => [
'aLevels' => ['Warning'],
'aExceptions' => [\Exception::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [1],
'logLevelMin' => null,
'iExpectedDbWriteNumber' => [0],
'logLevelMinWriteInDb' => null,
],
'enabled' => [
'aLevels' => ['Debug'],
'aExceptions' => [\Exception::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [1],
'logLevelMin' => ['Exception' => 'Debug'],
'iExpectedDbWriteNumber' => [1],
'logLevelMinWriteInDb' => ['Exception' => 'Debug'],
],
'file: 2 enabled, 2 filtered, db: 1 enabled, 3 filtered' => [
'aLevels' => ['Debug', 'Trace', 'Warning', 'Error'],
'aExceptions' => [\Exception::class, \Exception::class, \Exception::class, \Exception::class],
'sChannel' => 'Exception',
'aExpectedWriteNumber' => [0, 0, 1, 1],
'logLevelMin' => null,
'iExpectedDbWriteNumber' => [0, 0, 0, 1],
'logLevelMinWriteInDb' => null,
],
];
}
}