mirror of
https://github.com/Combodo/iTop.git
synced 2026-07-10 16:56:40 +02:00
e1ffa65d8b
* Rebase onto develop * Use exit condition instead of englobing condition * Add informative modals that can be called from modal toolbox * Refactor "apply_modify" and "apply_new" into own controller, handle ajax requests with a json response and handle these responses in linkset creation/edition * Fix merge issues * Remove inverted condition * Move linkset create button to a better place, still needs to fix duplicate "New" button caused by a refactor * Handle "Cancel" button in modals * Do not display relations when editing an object in a modal * More elegant way to add "New" button to relations lists * Factorize vertical highlights in alerts and modal in a single mixin * Replace button name with dict entry code * Change route name to snake case * More elegant way to add "Create in modal" button to relations lists * Replace triple if with in_array * Move listener to body * Rename variable to match boolean rules * Rename event * Rename extra param * Add phpdoc * Revert changes * Check indirect linkset rights before allowing creation in modal
JS for iTop
File location
In order to better separate our developments from the embedded third-party libs, files should be moved in either the /components or /lib folders.
IMPORTANT: Before moving a file, we should first consider if:
- The file is used in an iTop extension that should be compatible with the iTop version currently under developments
- The file is still used in iTop itself (or if we can consider removing it for clean up)
Leading semicolon
When concataining 2 files with code execution, we might have a prb.
For example :
// file A
(A)()
// file B
(B)()
Having (A)()(B)() is different than (A)();(B)(); !
To avoid those problems simply add a leading semicolon on all JS files.