mirror of
https://github.com/Combodo/iTop.git
synced 2026-06-08 17:12:43 +02:00
de4ec9d9ce
* N°9128 - Update CKEditor5 to v48 * Move some CSS vars to ckeditor, align variable overload in portal and backoffice * Add specifics to 3.2 portal * Update CKEditor5 build files * Update scssphp with patched version that handles pseudo selectors and attribute selectors * Update scssphp patched version to fix missing $this * Fix translations specific language file import * Remove unused maximize parameters * Update CKEditor5 build files * Fix font size/color for 3.2 portal * Avoid CKEditor styles from bleeding into fields
JS for iTop
File location
In order to better separate our developments from the embedded third-party libs, files should be moved in either the /js/components, /lib, /node_modules folders.
IMPORTANT: Before moving a file, we should first consider if:
- The file is used in an iTop extension that should be compatible with the iTop version currently under developments
- The file is still used in iTop itself (or if we can consider removing it for clean up)
Leading semicolon
When concataining 2 files with code execution, we might have a prb.
For example :
// file A
(A)()
// file B
(B)()
Having (A)()(B)() is different than (A)();(B)(); !
To avoid those problems simply add a leading semicolon on all JS files.