mirror of
https://github.com/Combodo/iTop.git
synced 2026-02-13 07:24:13 +01:00
Undefined offset notice was changed to a warning in PHP 8.0... Also message was changed :(
62 lines
2.0 KiB
PHP
62 lines
2.0 KiB
PHP
<?php
|
|
/*
|
|
* @copyright Copyright (C) 2010-2023 Combodo SARL
|
|
* @license http://opensource.org/licenses/AGPL-3.0
|
|
*/
|
|
|
|
namespace Combodo\iTop\Test\UnitTest\Core\Log;
|
|
|
|
|
|
use Combodo\iTop\Test\UnitTest\ItopTestCase;
|
|
use DeprecatedCallsLog;
|
|
use PHPUnit\Framework\Error\Notice;
|
|
use PHPUnit\Framework\Error\Warning;
|
|
|
|
class DeprecatedCallsLogTest extends ItopTestCase {
|
|
/**
|
|
* We are testing for a undefined offset error. This was throwing a Notice, but starting with PHP 8.0 it was converted to a Warning ! Also the message was changed :(
|
|
*
|
|
* @link https://www.php.net/manual/en/migration80.incompatible.php check "A number of notices have been converted into warnings:"
|
|
*/
|
|
private function SetUndefinedOffsetExceptionToExpect(): void {
|
|
if (version_compare(phpversion(), '8.0', '>=')) {
|
|
$sUndefinedOffsetExceptionClass = Warning::class;
|
|
$sUndefinedOffsetExceptionMessage = 'Undefined array key "tutu"';
|
|
}
|
|
else {
|
|
$sUndefinedOffsetExceptionClass = Notice::class;
|
|
$sUndefinedOffsetExceptionMessage = 'Undefined index: tutu';
|
|
}
|
|
$this->expectException($sUndefinedOffsetExceptionClass);
|
|
$this->expectExceptionMessage($sUndefinedOffsetExceptionMessage);
|
|
}
|
|
|
|
public function testPhpNoticeWithoutDeprecatedCallsLog(): void {
|
|
$this->SetUndefinedOffsetExceptionToExpect();
|
|
|
|
$aArray = [];
|
|
if ('toto' === $aArray['tutu']) {
|
|
//Do nothing, just raising a undefined offset warning
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The error handler set by DeprecatedCallsLog during startup was causing PHPUnit to miss PHP notices like "undefined offset"
|
|
*
|
|
* The error handler is now disabled when running PHPUnit
|
|
*
|
|
* @since 3.0.4 N°6274
|
|
* @covers DeprecatedCallsLog::DeprecatedNoticesErrorHandler
|
|
*/
|
|
public function testPhpNoticeWithDeprecatedCallsLog(): void {
|
|
$this->RequireOnceItopFile('core/log.class.inc.php');
|
|
DeprecatedCallsLog::Enable(); // will set error handler
|
|
$this->SetUndefinedOffsetExceptionToExpect();
|
|
|
|
$aArray = [];
|
|
if ('toto' === $aArray['tutu']) {
|
|
//Do nothing, just raising a undefined offset warning
|
|
}
|
|
}
|
|
}
|