mirror of
https://github.com/Combodo/iTop.git
synced 2026-04-21 17:48:43 +02:00
2f30a0146e
* N°6974 - Flatten classes in datamodel * N°6882 - LoadDelta() in lax/strict mode * N°6974 - Flatten classes in datamodel * N°6882 - LoadDelta() in lax/strict mode * N°7186 - Code hardening * N°6974 - Flatten classes in datamodel * N°6660 and N°7318 - Support delete_if_exists and define_if_not_exists in XML injection * N°6974 - Flatten classes in datamodel * Apply suggestions from code review * Update core/designdocument.class.inc.php --------- Co-authored-by: Molkobain <lajarige.guillaume@free.fr>
JS for iTop
File location
In order to better separate our developments from the embedded third-party libs, files should be moved in either the /js/components, /lib, /node_modules folders.
IMPORTANT: Before moving a file, we should first consider if:
- The file is used in an iTop extension that should be compatible with the iTop version currently under developments
- The file is still used in iTop itself (or if we can consider removing it for clean up)
Leading semicolon
When concataining 2 files with code execution, we might have a prb.
For example :
// file A
(A)()
// file B
(B)()
Having (A)()(B)() is different than (A)();(B)(); !
To avoid those problems simply add a leading semicolon on all JS files.